Skip to content

(ios) Description was missing for outgoing payments using Bolt 12 #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robbiehanson merged 1 commit into from
Oct 13, 2025
+8 −2
Merged

(ios) Description was missing for outgoing payments using Bolt 12 #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions phoenix-ios/phoenix-ios/kotlin/KotlinExtensions+Payments.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,11 @@ extension WalletPaymentInfo {

if let lightningPayment = outgoingPayment as? Lightning_kmpLightningOutgoingPayment {

if let normal = lightningPayment.details.asNormal() {
return sanitize(normal.paymentRequest.desc)
if let bolt11 = lightningPayment.details.asNormal() {
return sanitize(bolt11.paymentRequest.desc)

} else if let bolt12 = lightningPayment.details.asBlinded() {
return sanitize(bolt12.paymentRequest.description_)

} else if let swapOut = lightningPayment.details.asSwapOut() {
return sanitize(swapOut.address)
Expand Down
3 changes: 3 additions & 0 deletions phoenix-shared/src/iosMain/kotlin/fr/acinq/phoenix/utils/LightningExposure.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ fun LightningOutgoingPayment.explainAsFinalFailure(): FinalFailure? {
fun LightningOutgoingPayment.Details.asNormal(): LightningOutgoingPayment.Details.Normal? =
(this as? LightningOutgoingPayment.Details.Normal)

fun LightningOutgoingPayment.Details.asBlinded(): LightningOutgoingPayment.Details.Blinded? =
(this as? LightningOutgoingPayment.Details.Blinded)

@Suppress("DEPRECATION")
fun LightningOutgoingPayment.Details.asSwapOut(): LightningOutgoingPayment.Details.SwapOut? =
(this as? LightningOutgoingPayment.Details.SwapOut)
Expand Down