Skip to content

(ios) Display FinalWallet balance on HomeScreen#667

Merged
robbiehanson merged 6 commits into
masterfrom
ios-final-wallet-balance
Feb 17, 2025
Merged

(ios) Display FinalWallet balance on HomeScreen#667
robbiehanson merged 6 commits into
masterfrom
ios-final-wallet-balance

Conversation

@robbiehanson
Copy link
Copy Markdown
Contributor

If the user has funds in their FinalWallet, that information is now included in the "incoming balance" information on the HomeScreen. Also, tapping that balance will now show a popover that mirrors recent changes on Android:

Also added a badge for the HomeScreen that counts in-flight payments (mirrors Android UI changes in #522 ):

@dpad85
Copy link
Copy Markdown
Member

dpad85 commented Jan 10, 2025

Note, the pendingChannelsBalance coming from the BalanceManager is going to be removed in the database migration update. It's not useful anymore, it's always 0 since the new on-the-fly funding mechanism (ACINQ/lightning-kmp#649) which circumvents the issue altogether. So we'll soon be able to clean up some code.

@dpad85
Copy link
Copy Markdown
Member

dpad85 commented Jan 17, 2025

Nitpick, I think the popover would look better if the background was gray and the buttons white.

@robbiehanson robbiehanson force-pushed the ios-final-wallet-balance branch from 0d0b2ca to a654653 Compare January 17, 2025 19:48
@robbiehanson robbiehanson force-pushed the ios-final-wallet-balance branch from a654653 to 5e6b4f1 Compare February 11, 2025 19:55
@robbiehanson
Copy link
Copy Markdown
Contributor Author

Updated colors:

@robbiehanson robbiehanson merged commit 84ae238 into master Feb 17, 2025
@robbiehanson robbiehanson deleted the ios-final-wallet-balance branch February 17, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants