Ignore expired utxos migrated from the legacy app#681
Merged
Conversation
When migrating from the legacy android app, we allowed unconfirmed utxos to be able to do an instantaneous migration. But we allowed *all* utxos coming from the legacy app instead of only allowing unconfirmed and weakly confirmed ones. That also included swap-in-potentiam utxos that expired (for example because they were too small to be economical), which are automatically rejected by the LSP because they can be double spent. The result is that we are unable to complete swaps if we have an expired utxo coming from a migration from the legacy application. We fix this by only whitelisting unconfirmed and weakly confirmed utxos. Note that we will remove the migration code entirely when we merge#649.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When migrating from the legacy android app, we allowed unconfirmed utxos to be able to do an instantaneous migration. But we allowed all utxos coming from the legacy app instead of only allowing unconfirmed and weakly confirmed ones. That also included swap-in-potentiam utxos that expired (for example because they were too small to be economical), which are automatically rejected by the LSP because they can be double spent.
The result is that we are unable to complete swaps if we have an expired utxo coming from a migration from the legacy application. We fix this by only whitelisting unconfirmed and weakly confirmed utxos.
Note that we will remove the migration code entirely when we merge #649.
Fixes ACINQ/phoenix#582