Remove hack in the Invitations backend

app/models/invitation.rb

@@ -24,7 +24,7 @@ class Invitation < ApplicationRecord
 
   # Build new user on information in this invitation.
   def make_user(params = {})
-    self.user = account.users.build_with_fields params.reverse_merge(email: email, invitation: self)
+    self.user = account.users.build_with_fields params.reverse_merge(email: email)
   end
 
   def accepted?

app/models/user/invitations.rb

@@ -4,10 +4,7 @@ module User::Invitations
   included do
     after_commit :accept_invitation, :on => :create
 
-    attr_accessor :invitation
-
-    # TODO: refactor to make this work removing above attribute.
-    # has_one :invitation
+    has_one :invitation # rubocop:disable Rails/HasManyOrHasOneDependent -- before_destroy :destroy_invitation handles it
 
     before_destroy :destroy_invitation
   end
@@ -18,7 +15,8 @@ def accept_invitation
 
   def destroy_invitation
     if account # some tests fail because of account being nil
-      invit = account.invitations.find_by_email(email) || account.invitations.find_by_user_id(id) # || eventually invitation
+      invitations = account.invitations
+      invit = invitations.find_by(email: email) || invitations.find_by(user_id: id)
       # halt the destruction if the destruction of invitation failed
       throw :abort if invit && invit.destroy == false
     end

test/integration/developer_portal/accounts/invitee_signups_controller_test.rb

@@ -46,6 +46,7 @@ def setup
 
     assert_equal I18n.t('developer_portal.accounts.invitee_signups.create.success'), flash[:notice]
     assert_redirected_to login_path
+    assert invitation.reload.accepted?
   end
 
   test 'create pushes webhook' do

test/integration/provider/invitee_signups_controller_integration_test.rb

@@ -26,6 +26,7 @@ def setup
 
     assert_equal I18n.t('provider.invitee_signups.create.success'), flash[:success]
     assert_redirected_to provider_login_path
+    assert invitation.reload.accepted?
   end
 
   test 'do not set unpermitted attributes' do

test/unit/authentication/strategy/oauth2_test.rb

@@ -334,6 +334,7 @@ class SsoSignupTest < ActiveSupport::TestCase
           assert_equal result.username, user_data[:username]
           assert result.active?
           assert authentication_strategy.error_message.blank?
+          assert invitation.reload.accepted?
         end
       end
     end

test/unit/authentication/strategy/provider_oauth2_test.rb

@@ -258,6 +258,7 @@ class SsoSignupTest < ActiveSupport::TestCase
           assert_equal result.username, user_data[:username]
           assert result.active?
           assert authentication_strategy.error_message.blank?
+          assert invitation.reload.accepted?
         end
       end
     end