-
Notifications
You must be signed in to change notification settings - Fork 73
🚧 Big CSS Cleanup #4170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
josemigallas
wants to merge
13
commits into
master
Choose a base branch
from
THREESCALE-12047_clean_up_css
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
🚧 Big CSS Cleanup #4170
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8aec018
remove label in codemirror input instead of hiding via css
josemigallas 8c50b06
👯 removes pf_link_to duplication
josemigallas facdc47
🔧 updates stylelint config for CSS cleanup
josemigallas 71ba569
🦋 overhauls SCSS color system with PF variables
josemigallas 350d33e
🔥 removes dead SCSS files and theme imports
josemigallas 689f4d6
🦋 replaces _main.scss with provider.scss
josemigallas e6c361d
🦋 overhauls CMS styles with PF components
josemigallas 07ad115
🦋 consolidates API integration styles
josemigallas b7620a8
🦋 replaces call-to-action with PF banner
josemigallas db59afe
🦋 adopts PF layout for stats CSV button
josemigallas 3dc6a74
♻️ modernizes view templates and asset loading
josemigallas 86bb1f1
♻️ refactors wizard stylesheet
josemigallas e12f200
🥒 fixes cucumbers
josemigallas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| app/assets/stylesheets/vendor/**/*.scss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,130 +1,15 @@ | ||
| @charset 'utf-8'; | ||
|
|
||
| // Descriptive color names | ||
| // based on color names with main color attached for clarity if needed http://chir.ag/projects/name-that-color/ | ||
|
|
||
| /* TODO: can we use actual PF vars? */ | ||
| // greys | ||
| $alabasterWhite: #fafafa; // pf-black-100 | ||
| $altoGray: #d2d2d2; // pf-black-300 | ||
| $black: #030303; // pf-black | ||
| $osloGray: #8a8d90; // pf-black-500 | ||
| $outerSpaceGray: #3c3f42; // pf-black-800 | ||
| $gallery: #f0f0f0; // pf-black-200 | ||
| $white: #fff; | ||
| $whiteBoxShadowColor: rgba(3, 3, 3, 0.2); | ||
| $whiteBoxShadow: $whiteBoxShadowColor 0 1px 2px 0; | ||
| $wildSandGray: #f5f5f5; // pf-black-150 | ||
|
|
||
| // colors | ||
| $curiousBlue: #2b9af3; // pf-blue-300 | ||
| $lochMaraBlue: #06c; // pf-blue-400 | ||
| $appleGreen: #3f9c35; | ||
| $guardsmanRed: #c00; | ||
| $tahitiGold: #ec7a08; | ||
|
|
||
| // brand colors | ||
| $brand-orange: #ff7314; | ||
| $twitter-color: #55acee; | ||
| $facebook-color: #3b5998; | ||
|
|
||
| // Functional color names | ||
| $body-background: $white; | ||
| $content-background: $gallery; | ||
| $background-color-base: $body-background; | ||
| $font-color: $outerSpaceGray; | ||
| $color-base: $font-color; | ||
| $light-background-color: $alabasterWhite; | ||
| $label-color: $osloGray; | ||
| $highlight-color: $lochMaraBlue; | ||
| $border-color: $altoGray; | ||
| $select-color: $border-color; | ||
| $focus-color: $alabasterWhite; | ||
| $brand-blue: $lochMaraBlue; | ||
| $light-color: $osloGray; | ||
| $form-background-color: $white; | ||
| $hint-color: $osloGray; | ||
| $link-color: $highlight-color; | ||
| $link-hover-color: $outerSpaceGray; | ||
| $icon-hover-color: $lochMaraBlue; | ||
| $dirty-color: $alabasterWhite; | ||
| $success-color: $appleGreen; | ||
| $error-color: $guardsmanRed; | ||
| $error-background-color: rgba($error-color, 0.1); | ||
| $disabled-color: $osloGray; | ||
| $disabled-background-color: $wildSandGray; | ||
| $placeholder-color: $osloGray; | ||
| $create-color: $success-color; | ||
| $delete-color: $error-color; | ||
| $delete-background-color: $error-background-color; | ||
| $warning-color: $tahitiGold; | ||
| $body-background: white; | ||
| $border-color: var(--pf-global--palette--black-300); | ||
| $disabled-color: var(--pf-global--disabled-color--100); | ||
| $error-color: var(--pf-global--danger-color--100); | ||
| $font-color: var(--pf-global--Color--100); | ||
| $highlight-color: var(--pf-global--primary-color--100); | ||
| $label-color: var(--pf-global--palette--black-500); | ||
| $light-color: var(--pf-global--Color--200); | ||
| $link-color: var(--pf-global--link--Color); | ||
| $link-hover-color: var(--pf-global--primary-color--200); | ||
| $success-color: var(--pf-global--success-color--100); | ||
| $warning-color: var(--pf-global--warning-color--100); | ||
| $warning-color-hover: var(--pf-global--warning-color--200); | ||
| $table-search-background-color: $light-background-color; | ||
| $tr-odd-color: transparent; | ||
| $tr-even-color: transparent; | ||
| $wrapper-color: none; | ||
| $header-background-color: $black; | ||
| $header-border-color: $curiousBlue; | ||
| $tab-menu-active-color: $lochMaraBlue; | ||
| $tab-menu-active-background-color: $content-background; | ||
| $tab-content-color: $content-background; | ||
|
|
||
| // view specific colors | ||
| $overview-widget-border: $border-color; | ||
| $overview-widget-background: $tab-content-color; | ||
| $box-shadow-color: rgba($font-color, .1); | ||
| $menu-background-color: $content-background; | ||
| $menu-color: $outerSpaceGray; | ||
| $menu-active-color: $lochMaraBlue; | ||
| $menu-hover-color: $lochMaraBlue; | ||
| $submenu-color: $menu-color; | ||
| $submenu-hover-color: $menu-hover-color; | ||
| $submenu-active-color: $menu-active-color; | ||
| $submenu-border-color: $border-color; | ||
| $chart-background-color: $white; | ||
| $sample-data-color: $white; | ||
| $sample-data-bg-color: $lochMaraBlue; | ||
| $sample-data-border-color: $lochMaraBlue; | ||
| $important-button-color: $white; | ||
| $important-button-bg-color: $lochMaraBlue; | ||
| $important-button-border-color: $lochMaraBlue; | ||
| $secondary-button-color: $white; | ||
| $secondary-button-bg-color: $osloGray; | ||
| $secondary-button-border-color: $osloGray; | ||
| $disabled-button-color: $white; | ||
| $disabled-button-bg-color: $altoGray; | ||
| $disabled-button-border-color: $altoGray; | ||
| $glow-color: $highlight-color; | ||
| $glow-background-color: $wildSandGray; | ||
|
|
||
| /// --- login --- | ||
|
|
||
| $login-content-color: $font-color; | ||
| $codemirror-color: $label-color; | ||
| $codemirror-border: $content-background; | ||
| $codemirror-bg: $content-background; | ||
| $codemirror-bg-readonly: $codemirror-bg; | ||
| $codemirror-color-readonly: $codemirror-color; | ||
| $codemirror-cursor-color: $highlight-color; | ||
| $codemirror-vars-color: #00b9e4; // pf-light-blue-400 | ||
| $codemirror-vars2-color: #703fec; // pf-purple-400 | ||
| $codemirror-selected-bg: $select-color; | ||
| $codemirror-meta-color: $tahitiGold; | ||
| $codemirror-attr-color: $tahitiGold; | ||
| $codemirror-number-color: $tahitiGold; | ||
| $codemirror-comment-color: $label-color; | ||
| $codemirror-keyword-color: $tahitiGold; | ||
| $codemirror-builtin-color: $highlight-color; | ||
| $codemirror-color-def: $tahitiGold; | ||
| $codemirror-color-tag: $tahitiGold; | ||
| $codemirror-liquid-bg-color: transparent; | ||
| $codemirror-liquid-color: $highlight-color; | ||
| $codemirror-liquid-tag-color: $label-color; | ||
| $codemirror-liquid-markup-delim-color: $highlight-color; | ||
| $codemirror-liquid-string-color: $success-color; | ||
| $codemirror-gutter-color: $border-color; | ||
| $codemirror-gutter-background-color: $codemirror-bg; | ||
|
|
||
| :root { | ||
| --body-background-color: white; | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Low risk — 95 SCSS variables removed, but all internal references cleaned up.
95 SCSS variables were removed and 12 redefined to use PF CSS custom properties. The PR has cleaned up all internal references across 64 SCSS files — zero dangling references remain on the PR branch. No Sass color functions (
darken(),lighten(), etc.) are called on the redefined variables.The only remaining risk is for downstream forks or out-of-tree SCSS that imports these variables by name. Within this repo the migration is clean.