Disable synthetic test for deployment update - #1187
Merged
Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
The normal reconcile does not generate updates, this is checked. There was additional code to trigger a synthetic reconcile of one deployment to make sure the logging testing code is working. This has been disabled because it is currently flaky and preventing merges - it will be fixed in follow on PR.
borisurbanik
force-pushed
the
bu-disable-log-counter
branch
from
August 11, 2026 05:22
ca87d1d to
986a3ba
Compare
Contributor
|
/ltgm |
tkan145
approved these changes
Aug 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1187 +/- ##
==========================================
+ Coverage 44.03% 44.55% +0.51%
==========================================
Files 204 205 +1
Lines 20960 21171 +211
==========================================
+ Hits 9230 9433 +203
- Misses 10933 10938 +5
- Partials 797 800 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting part of the integration test due to the PR #1181 is failing integration test consistently now.
The normal reconcile does not generate updates,
this is checked.
There was additional code to trigger a synthetic
reconcile of one deployment to make sure the
logging testing code is working.
This has been disabled because it is currently
flaky and preventing merges - it will be fixed
in follow on PR.