Adding Developer Portal Scope to Tokens Tests - #1037
Open
cathal-bailey wants to merge 2 commits into
Open
Conversation
cathal-bailey
force-pushed
the
updating-tokens-scope-tests
branch
from
May 19, 2026 14:59
eb7fc0a to
71ff44d
Compare
cathal-bailey
changed the title
cathal-bailey
force-pushed
the
updating-tokens-scope-tests
branch
3 times, most recently
from
May 21, 2026 12:42
4de81b6 to
956b08d
Compare
cathal-bailey
marked this pull request as ready for review
May 21, 2026 12:45
mastastny
requested changes
Aug 6, 2026
mastastny
left a comment
mastastny
left a comment
Collaborator
There was a problem hiding this comment.
Docstrings Don't Meet CONTRIBUTING.md Requirements
I noticed the docstrings in this PR describe expected results rather than manual reproduction steps, which doesn't quite align with CONTRIBUTING.md guidelines. I think it would be helpful to update them to include explicit steps for manual reproduction. Also, I feel the test_developer_portal.py module docstring could be more comprehensive
Code Duplication
I see that test_get_cms_templates, test_get_cms_sections, and test_get_cms_files are nearly identical, differing only in the expected status code. I think parametrizing these tests would reduce code duplication and improve maintainability. The same duplication is also in other files.
cathal-bailey
force-pushed
the
updating-tokens-scope-tests
branch
from
August 11, 2026 14:21
6b02b56 to
dbc1a32
Compare
mastastny
reviewed
Aug 17, 2026
…lling, Analytics, and Policy Registry
cathal-bailey
force-pushed
the
updating-tokens-scope-tests
branch
from
August 18, 2026 12:22
d08a7d2 to
5a952be
Compare
mastastny
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_create_invoice_line_item.tokens.py