Skip to content

miner, consensus/bor: fix leaked-wedge family in worker state machine #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cffls wants to merge 7 commits into
base: develop
Choose a base branch
from

miner, consensus/bor: scope pendingTasks cleanup to Seal stop-branch …

dbfe887
Select commit
Loading
Failed to load commit list.
Open

miner, consensus/bor: fix leaked-wedge family in worker state machine #2220

miner, consensus/bor: scope pendingTasks cleanup to Seal stop-branch …
dbfe887
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 13, 2026 in 17m 44s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit tests/bor/bor_test.go:2954-2955 Stale docstrings reference pre-revision interrupt-deletes-pendingTasks design

Annotations

Check warning on line 2955 in tests/bor/bor_test.go

See this annotation in the file changed.

@claude claude / Claude Code Review

Stale docstrings reference pre-revision interrupt-deletes-pendingTasks design 

Two docstrings still describe the PR's pre-revision interrupt-deletes-pendingTasks design after commit dbfe887 inverted the cleanup direction. (1) `tests/bor/bor_test.go:2954-2955` references unit test `TestTaskLoopInterruptCleansStalePendingTasks` — a name that does not exist anywhere in the repo (the actual test is `TestTaskLoopInterruptPreservesPendingTasks` at `miner/worker_test.go:1695`, which asserts the OPPOSITE semantic: that `interrupt()` must NOT delete pendingTasks). (2) `miner/worker
View more details on Claude