Skip to content

miner, core, consensus/bor, eth, triedb: pipelined state root computation (PoC) #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pratikspatil024 wants to merge 29 commits into
base: delay_src
Choose a base branch
from

miner: async DB write, concurrent fill, and interrupt timer improvements

3dcdf80
Select commit
Loading
Failed to load commit list.
Draft

miner, core, consensus/bor, eth, triedb: pipelined state root computation (PoC) #2180

miner: async DB write, concurrent fill, and interrupt timer improvements
3dcdf80
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 1, 2026 in 1m 5s

Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check failure on line 153 in miner/pipeline.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 95 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLOWMy6llO4qwxL5&open=AZ1JxLOWMy6llO4qwxL5&pullRequest=2180

Check warning on line 74 in core/evm_speculative_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestSpeculativeGetHashFn_Tier1_LazyResolve" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLJqMy6llO4qwxLu&open=AZ1JxLJqMy6llO4qwxLu&pullRequest=2180

Check warning on line 51 in miner/speculative_chain_reader_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestSpeculativeChainReader_InterceptsPlaceholder" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLPbMy6llO4qwxL8&open=AZ1JxLPbMy6llO4qwxL8&pullRequest=2180

Check failure on line 1216 in consensus/bor/bor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Error while committing states" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLOFMy6llO4qwxL4&open=AZ1JxLOFMy6llO4qwxL4&pullRequest=2180

Check warning on line 769 in miner/pipeline.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 9 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLOWMy6llO4qwxL6&open=AZ1JxLOWMy6llO4qwxL6&pullRequest=2180

Check warning on line 163 in core/evm_speculative_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestSpeculativeGetHashFn_FutureBlock" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLJqMy6llO4qwxLx&open=AZ1JxLJqMy6llO4qwxLx&pullRequest=2180

Check warning on line 52 in core/state/statedb_pipeline_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestFlatDiffOverlay_ReadThrough" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLFyMy6llO4qwxLs&open=AZ1JxLFyMy6llO4qwxLs&pullRequest=2180

Check failure on line 4387 in core/blockchain.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 32 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLKnMy6llO4qwxL1&open=AZ1JxLKnMy6llO4qwxL1&pullRequest=2180

Check failure on line 62 in miner/speculative_chain_reader_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "block9-pending" 4 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLPbMy6llO4qwxL7&open=AZ1JxLPbMy6llO4qwxL7&pullRequest=2180

Check failure on line 611 in tests/bor/helper.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "0.0.0.0:0" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLQwMy6llO4qwxMD&open=AZ1JxLQwMy6llO4qwxMD&pullRequest=2180

Check warning on line 107 in core/evm_speculative_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestSpeculativeGetHashFn_Tier2_ImmediateParent" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLJqMy6llO4qwxLv&open=AZ1JxLJqMy6llO4qwxLv&pullRequest=2180

Check failure on line 1207 in consensus/bor/bor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Error while committing span" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLOFMy6llO4qwxL2&open=AZ1JxLOFMy6llO4qwxL2&pullRequest=2180

Check warning on line 183 in miner/speculative_chain_reader_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestSpeculativeChainReader_Config" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLPbMy6llO4qwxL_&open=AZ1JxLPbMy6llO4qwxL_&pullRequest=2180

Check warning on line 128 in core/evm_speculative_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestSpeculativeGetHashFn_Tier3_OlderBlocks" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLJqMy6llO4qwxLw&open=AZ1JxLJqMy6llO4qwxLw&pullRequest=2180

Check warning on line 2940 in tests/bor/bor_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestPipelinedSRC_BasicBlockProduction" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLQYMy6llO4qwxMB&open=AZ1JxLQYMy6llO4qwxMB&pullRequest=2180

Check warning on line 189 in core/evm_speculative_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestSpeculativeGetHashFn_Tier1_Blocking" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLJqMy6llO4qwxLy&open=AZ1JxLJqMy6llO4qwxLy&pullRequest=2180

Check failure on line 4249 in core/blockchain.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 31 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLKnMy6llO4qwxL0&open=AZ1JxLKnMy6llO4qwxL0&pullRequest=2180

Check failure on line 601 in tests/bor/helper.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "InitMiner-" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLQwMy6llO4qwxME&open=AZ1JxLQwMy6llO4qwxME&pullRequest=2180

Check failure on line 1229 in consensus/bor/bor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Error changing contract code" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLOFMy6llO4qwxL3&open=AZ1JxLOFMy6llO4qwxL3&pullRequest=2180

Check failure on line 2230 in core/blockchain.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Failed to write block into disk" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLKnMy6llO4qwxLz&open=AZ1JxLKnMy6llO4qwxLz&pullRequest=2180

Check warning on line 3009 in tests/bor/bor_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestPipelinedSRC_WithTransactions" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLQYMy6llO4qwxMC&open=AZ1JxLQYMy6llO4qwxMC&pullRequest=2180

Check warning on line 99 in miner/speculative_chain_reader_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestSpeculativeChainReader_DelegatesNonPlaceholder" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLPbMy6llO4qwxL9&open=AZ1JxLPbMy6llO4qwxL9&pullRequest=2180

Check warning on line 193 in miner/speculative_chain_reader_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestSpeculativeChainContext_Engine" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLPbMy6llO4qwxMA&open=AZ1JxLPbMy6llO4qwxMA&pullRequest=2180

Check warning on line 98 in core/state/statedb_pipeline_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestCommitSnapshot_CapturesWrites" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLFyMy6llO4qwxLt&open=AZ1JxLFyMy6llO4qwxLt&pullRequest=2180

Check warning on line 140 in miner/speculative_chain_reader_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestSpeculativeChainReader_WalkThroughPending" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLPbMy6llO4qwxL-&open=AZ1JxLPbMy6llO4qwxL-&pullRequest=2180
View more details on SonarQubeCloud