perf: parallel build_lookup_fractions + drop cycle_lookups#3119
Merged
perf: parallel build_lookup_fractions + drop cycle_lookups#3119
build_lookup_fractions + drop cycle_lookups#3119Conversation
Nashtare
force-pushed
the
robin/prover-perf-prep
branch
from
3dee123 to
0fa1510
Compare
huitseeker
approved these changes
May 8, 2026
Collaborator
huitseeker
left a comment
huitseeker
left a comment
There was a problem hiding this comment.
LGTM!, thanks for tackling this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Two small tweaks on the prover side.
build_aux_trace_logupis about 3.8x faster on my machine (150ms -> 40ms) when running./target/optimized/miden-vm prove ./miden-vm/masm-examples/hashing/blake3_1to1/blake3_1to1.masm --release --hasher poseidon2.cycle_lookupswas obsolete after #2962Supersedes #3090
closes #2793
Checklist before requesting a review
nextaccording to naming convention.