fix: reject empty kernel packages before linking#3082
Merged
huitseeker merged 1 commit into0xMiden:nextfrom May 6, 2026
Merged
fix: reject empty kernel packages before linking#3082huitseeker merged 1 commit into0xMiden:nextfrom
huitseeker merged 1 commit into0xMiden:nextfrom
Conversation
|
Automated check (CONTRIBUTING.md) Findings:
Recommendations:
Next steps:
|
4f3d731 to
a6a5ee8
Compare
huitseeker
approved these changes
May 4, 2026
Collaborator
There was a problem hiding this comment.
Thanks for the PR @KitaroMoha563 ! This LGTM.
Note for @bitwalker : @bobbinth had a comment suggesting kernel procedure digests might be derived from ModuleInfo rather than the package manifest. This PR goes a bit further in the current implementation’s direction instead.
bitwalker
approved these changes
May 4, 2026
a6a5ee8 to
d567b96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Reject kernel packages whose manifest does not export any
$kernelprocedures before converting them into a runtimeKernel.This turns malformed package metadata into a structured package error before it reaches the linker's non-empty-kernel assertion. Assemblers without a kernel still use the existing empty-kernel default.
Tests cover both direct package conversion and
Assembler::link_package()returning an error instead of unwinding.Checklist before requesting a review
nextaccording to naming convention.CHANGELOG.md