fix: preassembled runtime deps on main#2984
Closed
huitseeker wants to merge 3 commits intomainfrom
Closed
Conversation
Preassembled packages still need their runtime dependencies during resolution. Programs that need a kernel now fail when that kernel cannot be resolved, instead of silently falling back to embedded metadata during dependency selection. (cherry picked from commit a5bebe9)
(cherry picked from commit 64a692a)
huitseeker
added
the
no changelog
These protocol fixture deltas were introduced on main in 972f916 (test(assembly): add integration test for project assembly), after main and next had already diverged. Next already carries the protocol fixtures via #2877, but with different fixture semantics, and later rejects direct `exec.$kernel::init` references after cf48d0a (#2903). Remove the main-only `exec.$kernel::init` lines and the extra `miden-core` workspace wiring from the protocol fixtures. The packaging test still passes, and this eliminates the remaining fixture-only merge conflicts with next.
This was referenced Apr 9, 2026
Collaborator
Author
|
Will do something simpler. |
Merged
Collaborator
Author
|
Replaced by #2998 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is merge-prep for the upcoming
main->nextreconciliation (see #2878).#2950 contained some adjustments of the package PR (originally #2877) for
next.The present PR cherry-picks those adjustments to main, and is by consequence expected to remove 5 of the 18 conflicts on the tracking release branch. Another PR against next (#2985) will take care of the rest.