-
Notifications
You must be signed in to change notification settings - Fork 293
All-LogUp auxiliary trace bus constraints #2962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
107 commits
Select commit
Hold shift + click to select a range
0c71228
feat(air): all-LogUp bus refactor (squashed)
adr1anh 34aa578
refactor(air): adapt lookup module to 2856 unified Challenges + MainCols
adr1anh 5076ed6
refactor(air): port hash_kernel + chiplet_responses LogUp buses to 28…
adr1anh 2c1eae2
refactor(air): simplify LogUp bus emitters
adr1anh b871e61
refactor(air): split MidenLookupAir into Main/Chiplet sub-airs + bus …
adr1anh e94f78a
refactor(air): delete legacy LogUpMessage trait + unused Msg variants
adr1anh 91766ac
style(air): clean up lint + rustfmt warnings in logup_msg
adr1anh 0478814
feat(air): prover LogUp collection phase into flat LookupFractions
adr1anh 9c8b459
feat(air): real-trace driver for LogUp collection phase
adr1anh 64de7a9
feat(air): fused LogUp accumulator + constraint-path cross-check oracle
adr1anh 71c1f36
perf(air): row-major chunk-parallel fused LogUp accumulator
adr1anh dc9158b
feat(air): stateless MidenLookupAuxBuilder + LogUp prover wiring
adr1anh 93fa6f6
refactor(air,processor): delete legacy multiset bus + aux trace builders
adr1anh 97d576e
chore(processor): drop dead test helpers + unused imports
adr1anh 906c43c
test(processor): restore bitwise chiplet bus test via LogUp harness
adr1anh 5868081
feat(air): wire stack overflow + hasher perm-link LogUp buses
adr1anh 34f3936
feat(air): LogUp boundary check with open-bus corrections
adr1anh a568cab
chore(air,docs): fix CI feature-combo + MDX docs build
adr1anh 99e62f6
docs: remove all-LogUp PR design notes from the repo
adr1anh 16af1ef
feat(air,core-lib): implement LogUp boundary check in ACE circuit
adr1anh e91c9b6
refactor(air): address lookup builder review comments
adr1anh ea3949b
refactor(air): remove EncodedLookupGroup, unify into LookupGroup
adr1anh 4706691
feat(air): add name + degree annotations to lookup builder API
adr1anh 501e704
refactor(air): consolidate LogUp debug surface into lookup::debug
adr1anh 1307d06
refactor(air): make Challenges shape runtime-sized, move constants Mi…
adr1anh 12be381
refactor(air,processor): collapse kernel ROM chiplet to multiplicity-…
adr1anh d1dd3e2
refactor(air): drop F=Felt bound from lookup constraint/prover adapters
adr1anh d6f6cb3
refactor(air): split lookup module into generic + Miden-specific halves
adr1anh fb90230
refactor(air): generalize lookup validation; split into focused files
adr1anh ac7bd62
air: domain-separate chiplet interactions via BusId enum
adr1anh 7044801
air: replace Deg::NONE with measured LogUp interaction degrees
adr1anh 01d0d41
air: fix rustdoc broken links and doctest in ace.rs
adr1anh 5d4bc81
test(processor): add column-blind subset-based LogUp bus tests
adr1anh 6d6e82d
refactor(air): single-accumulator LogUp with aux_curr fraction columns
adr1anh 9626a41
air: drop redundant bus labels; swap block-hash payload order
adr1anh 03f2ff9
Merge remote-tracking branch 'origin/next' into adr1anh/bus
adr1anh a7fbaa7
air: add LogUp boundary emissions and structured debug push log
adr1anh 6e6e46d
chore: clippy cleanup across air and processor
adr1anh 12e14fa
refactor(air): split LogUp module surface into generic + Miden halves
adr1anh 02bddc6
chore: clean up stale artifacts post-LogUp bus refactor
adr1anh aaefb36
air: override log_quotient_degree for ProcessorAir
adr1anh 10198f6
refactor(air): collapse lookup validation into single validate() entr…
adr1anh 6f3402f
test(miden-vm): re-enable recursive verify + poseidon2 assertion
adr1anh a7dbe57
air: narrow bus OpFlags surface via LookupOpFlags
adr1anh aa1296d
air: prover-side boolean fast path for LookupOpFlags
adr1anh c7adc5b
chore(air): tighten kernel ROM docstrings in chiplets constraints
adr1anh 0ae488b
chore(air): drop blanket allow(dead_code, unused_imports) in lookup m…
adr1anh d34d2a6
refactor(air): hoist kernel ROM TRACE_WIDTH into trace/chiplets/mod.rs
adr1anh 55a5987
chore(processor): remove diagnostic eprintlns from lookup tests
adr1anh 3fb25b6
refactor(air): reduced_aux_values drives eval_boundary via BoundaryBu…
adr1anh 4e59120
refactor(air): drop public_values from LookupBuilder
adr1anh 156a554
style: apply clippy-fix + rustfmt after cherry-pick
adr1anh 043e411
refactor(air): rename validation/builder.rs to encoding.rs
adr1anh 94d68cd
refactor(air): unify debug validation into one walker
adr1anh 1420e78
docs: add changelog entry for PR #2962
adr1anh c23c71b
chore(core): revert small change to make diff smaller
adr1anh 4148374
fix(air): clean up dead code flagged by cargo-hack --no-default-features
adr1anh 0e7bfc4
fix(air): wire CryptoStream memory requests into LogUp chiplet_reques…
adr1anh ffe310e
refactor(air): collapse MidenLookupAir/MidenLookupAuxBuilder onto Pro…
adr1anh aa34a3b
chore: assert padding values are zero
adr1anh d177a59
Merge remote-tracking branch 'origin/next' into adr1anh/bus
adr1anh e37f7a2
fix(air): iterate op_bits directly in decode_opcode_u8
adr1anh 24feee2
docs(air): fix stale intra-doc link to build_logup_aux_trace
adr1anh bbcbae4
test(processor): restore lost coverage in LogUp bus tests
adr1anh 5a68dc7
docs(air): scrub stale multiset / running-product / SHA references
adr1anh f335413
docs(air): drop obsolete dead-code-suppression note in buses/mod.rs
adr1anh ca50494
docs(air): refresh stale legacy-enforce / in-flight-refactor prose
adr1anh e6d0eff
docs(air): consolidate NUM_LOGUP_COMMITTED_FINALS(#3032) TODO
adr1anh 4f204e9
docs(air): rewrite constraints/lookup/mod.rs header
adr1anh e8edcee
docs(air): rewrite messages.rs module header
adr1anh b0d1195
docs(air): retire BUS_* SCREAMING_SNAKE labels in comments
adr1anh 83222d6
chore(air): unify max_message_width across sub-AIRs
adr1anh 3ecabcd
chore(air): tighten ChipletActiveFlags visibility to pub(crate)
adr1anh 79cf4ce
chore(air): drop redundant self-rename in main_air.rs imports
adr1anh 12ea925
style(air): prefer direct method calls in ProcessorAir::eval
adr1anh c8da3b3
refactor(air): hoist clk_plus_one in chiplet_responses emitter
adr1anh 547fb84
refactor(air): loop over Merkle leaf-word response variants
adr1anh 485c855
refactor(air): unify SiblingMsgBitZero/BitOne and collapse bus loop
adr1anh d620bc7
refactor(air): merge BitwiseMsg and BitwiseResponseMsg
adr1anh 5dc48ca
refactor(air): lift HasherMsg kind into outer struct
adr1anh 986fa55
refactor(air): drop MemoryHeader; pass memory payload by value
adr1anh 454a348
chore(air): derive BusId::COUNT from the last variant
adr1anh 1d375d5
refactor(air): simplify LookupFractions allocator to from_shape
adr1anh 666a7f4
perf(air): avoid throwaway last-row Vec in build_logup_aux_trace
adr1anh 70d296c
air: enforce fraction columns are zero on the padding row
adr1anh ed99f0d
refactor(processor): drop unused _trace param from push_sibling
adr1anh cdc7e51
chore(processor): drop stale allow(dead_code) on build_span_with_resp…
adr1anh 444f6c0
test(processor): tighten hout_count guardrails to == N
adr1anh 1f22abf
docs(processor): rewrite chiplets/mod.rs test doc for subset semantics
adr1anh 291db30
refactor(processor): fold lookup.rs plumbing test into oracle cross-c…
adr1anh 90e25d3
style(processor): replace FQP miden_air::trace::MainTrace with top-of…
adr1anh f5f29c5
refactor(processor): merge tests/hasher.rs into tests/chiplets/hasher.rs
adr1anh 94d249a
style: apply cargo fmt across bus-cleanup commits
adr1anh f44e3e8
chore: resolve adr1anh review nits on PR #2962
adr1anh 1d12c6e
docs(air): scrub legacy LogUp column nicknames (M1/M_2+5/C1/...)
adr1anh 664fad3
refactor(air): tighten ProcessorAir LookupAir impl + drop reducer err…
adr1anh 99c1b2d
fix(air): address huitseeker review on PR #2962
adr1anh 3176d1f
fix(air): defend END→RESPAN, restore fallible boundary reducer
adr1anh e39e062
refactor(air): address huitseeker review nits on PR #2962
adr1anh c1b85c3
Merge remote-tracking branch 'origin/next' into adr1anh/bus
adr1anh 40db4bc
docs: trim decorative comments
adr1anh a47c4d4
docs: normalize bus-message section dividers
adr1anh b17f666
refactor: rename Deg{n,d}→Deg{v,u} and unify (V,U) ordering
adr1anh e92ca55
Merge remote-tracking branch 'origin/next' into adr1anh/bus
adr1anh 68b24ee
refactor: address huitseeker nits from PR #2962 approval
adr1anh 51bc0d5
Address PR 2962 review follow-ups
huitseeker c6ddc71
Merge remote-tracking branch 'origin/next' into adr1anh/bus
adr1anh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will simplify quite a lot in a followup PR, right ?