javascript: Fix and extend Biome configuration (#786)

Author: sonnyp

.eslintrc.yaml

@@ -42,7 +42,6 @@ rules:
   array-callback-return: [error] # https://eslint.org/docs/latest/rules/array-callback-return
   no-duplicate-imports: [error] # https://eslint.org/docs/latest/rules/no-duplicate-imports
   no-new-native-nonconstructor: [error] # https://eslint.org/docs/latest/rules/no-new-native-nonconstructor
-  # TODO: log and logError
   no-restricted-globals: # https://eslint.org/docs/rules/no-restricted-globals
     - error
     - window
@@ -54,8 +53,8 @@ rules:
   no-unused-vars: # https://eslint.org/docs/latest/rules/no-unused-vars
     - error
     - vars: all
-      args: none
-      ignoreRestSiblings: false
+      args: all
+      argsIgnorePattern: "^_"
 
   # Suggestions
   # https://eslint.org/docs/latest/rules/#suggestions

Makefile

@@ -9,8 +9,9 @@ setup:
 	flatpak-builder --ccache --force-clean --stop-at=gi-docgen flatpak build-aux/re.sonny.Workbench.Devel.json
 
 lint:
-# ESLint
+# JavaScript
 	./node_modules/.bin/eslint --max-warnings=0 src
+	./build-aux/fun biome ci --config-path=src/langs/javascript/ src/Library/demos/
 # rustfmt
 	./build-aux/fun rustfmt --check --edition 2021 src/**/*.rs
 # black

build-aux/modules/biome.json

@@ -7,15 +7,15 @@
       "type": "file",
       "dest-filename": "biome",
       "only-arches": ["aarch64"],
-      "url": "https://github.com/biomejs/biome/releases/download/cli%2Fv1.0.0/biome-linux-arm64",
-      "sha256": "debedada2fdb265020c986fce38fad4eb0dcd2ca09fb4d5d387bdb90bba2044a"
+      "url": "https://github.com/biomejs/biome/releases/download/cli%2Fv1.3.3/biome-linux-arm64",
+      "sha256": "3eac5c42c21f330a77f194ad10fd9cfa3e627512d999124405fb9e033223b6eb"
     },
     {
       "type": "file",
       "dest-filename": "biome",
       "only-arches": ["x86_64"],
-      "url": "https://github.com/biomejs/biome/releases/download/cli%2Fv1.0.0/biome-linux-x64",
-      "sha256": "c5aab82e7c18b706826238f4c1178de67479a004e72682afaa16f03f95864038"
+      "url": "https://github.com/biomejs/biome/releases/download/cli%2Fv1.3.3/biome-linux-x64",
+      "sha256": "f15e955a935ec1e255a626c4501048612a271539483f76d8d392b0cc7e80b42a"
     }
   ]
 }

data/app.gschema.xml

@@ -9,9 +9,6 @@
     <key name="color-scheme" type="i">
       <default>0</default>
     </key>
-    <key name="migrated" type="b">
-      <default>false</default>
-    </key>
     <key name="recent-code-language" type="i">
       <default>0</default>
     </key>

package.json

@@ -26,6 +26,9 @@
   "lint-staged": {
     "*.{css,json,md,yaml,yml}": "prettier --write",
     "*.{js,cjs,mjs}": "eslint --fix",
+    "src/Library/demos/**/*.{js,cjs,mjs}": [
+      "./build-aux/fun biome check --apply-unsafe --config-path=src/langs/javascript/"
+    ],
     "*.py": "./build-aux/fun black",
     "*.rs": "./build-aux/fun rustfmt --edition 2021",
     "*.blp": "./build-aux/fun blueprint-compiler format --fix"

src/Document.js

@@ -63,7 +63,7 @@ async function saveSourceBuffer({ source_file, buffer }) {
   }
 }
 
-async function loadSourceBuffer({ source_file, buffer, lang }) {
+async function loadSourceBuffer({ source_file, buffer }) {
   const file_loader = new Source.FileLoader({
     buffer,
     file: source_file,

src/Library/demos/About Window/main.js

@@ -1,6 +1,6 @@
+import { gettext as _ } from "gettext";
 import Adw from "gi://Adw";
 import Gtk from "gi://Gtk";
-import { gettext as _ } from "gettext";
 
 const parent = workbench.window;
 const button = workbench.builder.get_object("button");

src/Library/demos/Accessibility/main.js

@@ -9,7 +9,7 @@ clicker.connect("released", () => toggleButton(button));
 button.add_controller(clicker);
 
 const key_controller = new Gtk.EventControllerKey();
-key_controller.connect("key-released", (controller, keyval) => {
+key_controller.connect("key-released", (_controller, keyval) => {
   const keyvals = [
     Gdk.KEY_space,
     Gdk.KEY_KP_Space,

src/Library/demos/Account/main.js

@@ -1,7 +1,7 @@
+import Gdk from "gi://Gdk";
+import Gio from "gi://Gio";
 import Xdp from "gi://Xdp";
 import XdpGtk from "gi://XdpGtk4";
-import Gio from "gi://Gio";
-import Gdk from "gi://Gdk";
 
 Gio._promisify(
   Xdp.Portal.prototype,

src/Library/demos/Actions/main.js

@@ -1,5 +1,5 @@
-import Gio from "gi://Gio";
 import GLib from "gi://GLib";
+import Gio from "gi://Gio";
 
 const demo = workbench.builder.get_object("demo");