From ee30dac3a8519a6708ed55e94571b37790e3be2e Mon Sep 17 00:00:00 2001 From: tpluscode Date: Wed, 20 May 2026 11:12:12 +0200 Subject: [PATCH 1/4] build(deps): updated playwright --- CHANGELOG.md | 3 ++- app/package.json | 2 +- yarn.lock | 28 ++++++++++++++-------------- 3 files changed, 17 insertions(+), 16 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5e610c9a7..ca479e479 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,7 +29,7 @@ You can also check the makes Visualize winding order agnostic and fixes a specific bug with newer CCW geometries from Swisstopo where map diagrams were zoomed to the world instead of Switzerland (older geometries all had CW winding order). - - Improve dimension values query performance. + - Improve dimension values query performance. - Maintenance - Remove Google Analytics integration (it is no longer in use) - Set Maptiler API key from `MAPTILER_API_KEY` environment variable at @@ -40,6 +40,7 @@ You can also check the - Remove dependencies which used old versions of `node-fetch` - Upgrade dependencies which used old versions of `nth-check` - Updated `@deck.gl/*` packages and `fast-xml-parser` + - Upgrade playwright to v1.60 - Rename package - Documentation - Add publiccode.yml for discoverability diff --git a/app/package.json b/app/package.json index f623c4a91..69364c7ec 100644 --- a/app/package.json +++ b/app/package.json @@ -197,7 +197,7 @@ "@lingui/macro": "^4.0.0", "@mdx-js/loader": "^1.6.22", "@playwright-testing-library/test": "^4.5.0", - "@playwright/test": "^1.49.1", + "@playwright/test": "^1.60.0", "@svgr/cli": "^7", "@types/autosuggest-highlight": "^3.2.0", "@types/clownface": "^2.0.7", diff --git a/yarn.lock b/yarn.lock index a705f25bd..fc71b03d2 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5362,12 +5362,12 @@ "@testing-library/dom" "^7.31.2" wait-for-expect "^3.0.2" -"@playwright/test@^1.49.1": - version "1.49.1" - resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.49.1.tgz#55fa360658b3187bfb6371e2f8a64f50ef80c827" - integrity sha512-Ky+BVzPz8pL6PQxHqNRW1k3mIyv933LML7HktS8uik0bUXNCdPhoS/kLihiO1tMf/egaJb4IutXd7UywvXEW+g== +"@playwright/test@^1.60.0": + version "1.60.0" + resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.60.0.tgz#e696c31427e8882851235cd556dc2490c3206d97" + integrity sha512-O71yZIbAh/PxDMNGns37GHBIfrVkEVyn+AXyIa5dOTfb4/xNvRWV+Vv/NMbNCtODB/pO7vLlF2OTmMVLhmr7Ag== dependencies: - playwright "1.49.1" + playwright "1.60.0" "@pmmmwh/react-refresh-webpack-plugin@^0.5.11": version "0.5.11" @@ -17366,10 +17366,10 @@ pkg-up@^3.1.0: dependencies: find-up "^3.0.0" -playwright-core@1.49.1: - version "1.49.1" - resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.49.1.tgz#32c62f046e950f586ff9e35ed490a424f2248015" - integrity sha512-BzmpVcs4kE2CH15rWfzpjzVGhWERJfmnXmniSyKeRZUs9Ws65m+RGIi7mjJK/euCegfn3i7jvqWeWyHe9y3Vgg== +playwright-core@1.60.0: + version "1.60.0" + resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.60.0.tgz#24e0d9cc4730713db5dffcace29b5e4696b1907a" + integrity sha512-9bW6zvX/m0lEbgTKJ6YppOKx8H3VOPBMOCFh2irXFOT4BbHgrx5hPjwJYLT40Lu+4qtD36qKc/Hn56StUW57IA== playwright-testing-library@^4.5.0: version "4.5.0" @@ -17379,12 +17379,12 @@ playwright-testing-library@^4.5.0: "@testing-library/dom" "^7.31.2" wait-for-expect "^3.0.2" -playwright@1.49.1: - version "1.49.1" - resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.49.1.tgz#830266dbca3008022afa7b4783565db9944ded7c" - integrity sha512-VYL8zLoNTBxVOrJBbDuRgDWa3i+mfQgDTrL8Ah9QXZ7ax4Dsj0MSq5bYgytRnDVVe+njoKnfsYkH3HzqVj5UZA== +playwright@1.60.0: + version "1.60.0" + resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.60.0.tgz#89710863a51f21112633ef8b6b182594d3bfd7b5" + integrity sha512-hheHdokM8cdqCb0lcE3s+zT4t4W+vvjpGxsZlDnikarzx8tSzMebh3UiFtgqwFwnTnjYQcsyMF8ei2mCO/tpeA== dependencies: - playwright-core "1.49.1" + playwright-core "1.60.0" optionalDependencies: fsevents "2.3.2" From 827097d7093eb5a11b6be62553e9298123952a39 Mon Sep 17 00:00:00 2001 From: tpluscode Date: Wed, 20 May 2026 15:17:04 +0200 Subject: [PATCH 2/4] test: remove `screen` from chrome e2e test settings --- playwright.config.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/playwright.config.ts b/playwright.config.ts index b3a76bfe0..e13b076d1 100644 --- a/playwright.config.ts +++ b/playwright.config.ts @@ -60,7 +60,11 @@ export default defineConfig({ launchOptions: { args: ["--disable-web-security"], }, - ...devices["Desktop Chrome"], + ...Object.fromEntries( + Object.entries(devices["Desktop Chrome"]).filter( + ([key]) => key !== "screen" + ) + ), }, }, From 75829dd8cfe43c0238eacfddabd244633b77defa Mon Sep 17 00:00:00 2001 From: Max Burri Date: Tue, 26 May 2026 15:15:02 +0200 Subject: [PATCH 3/4] chore: use a smaller dataset for tooltip-test --- e2e/tooltip.spec.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/e2e/tooltip.spec.ts b/e2e/tooltip.spec.ts index 0f989190e..95fbe8782 100644 --- a/e2e/tooltip.spec.ts +++ b/e2e/tooltip.spec.ts @@ -57,7 +57,7 @@ test("should keep correct position after scrolling", async ({ actions, }) => { await actions.chart.createFrom({ - iri: "https://agriculture.ld.admin.ch/foag/cube/MilkDairyProducts/Consumption_Price_Month", + iri: "https://environment.ld.admin.ch/foen/ubd000502/8", dataSource: "Prod", }); await actions.editor.changeRegularChartType("Bars"); @@ -66,8 +66,8 @@ test("should keep correct position after scrolling", async ({ const rect0 = chart.locator('[data-index="0"]'); await rect0.hover({ force: true }); await sleep(3_000); - const rect50 = chart.locator('[data-index="50"]'); - await rect50.hover({ force: true }); + const rect30 = chart.locator('[data-index="30"]'); + await rect30.hover({ force: true }); await sleep(3_000); const tooltip = page.locator('[data-testid="chart-tooltip"]'); await tooltip.waitFor({ state: "attached", timeout: 1_000 }); From 99fd637502fbc6fa17df3f2cecf4be23f74e25c0 Mon Sep 17 00:00:00 2001 From: Max Burri Date: Wed, 27 May 2026 11:18:35 +0200 Subject: [PATCH 4/4] experiment: just remove the device config --- playwright.config.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/playwright.config.ts b/playwright.config.ts index e13b076d1..055457fd0 100644 --- a/playwright.config.ts +++ b/playwright.config.ts @@ -1,4 +1,4 @@ -import { defineConfig, devices } from "@playwright/test"; +import { defineConfig } from "@playwright/test"; /** * Read environment variables from file. @@ -60,11 +60,7 @@ export default defineConfig({ launchOptions: { args: ["--disable-web-security"], }, - ...Object.fromEntries( - Object.entries(devices["Desktop Chrome"]).filter( - ([key]) => key !== "screen" - ) - ), + //...devices["Desktop Chrome"], }, },