Skip to content

Add oidc support#374

Merged
luismeyer merged 10 commits into
mainfrom
oidc
May 28, 2026
Merged

Add oidc support#374
luismeyer merged 10 commits into
mainfrom
oidc

Conversation

@luismeyer
Copy link
Copy Markdown
Member

@luismeyer luismeyer commented May 4, 2026

No description provided.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flags-playground Ready Ready Preview, Comment, Open in v0 May 28, 2026 6:39am
flags-sdk-dev Ready Ready Preview, Comment, Open in v0 May 28, 2026 6:39am
flags-sdk-next-15 Ready Ready Preview, Comment, Open in v0 May 28, 2026 6:39am
flags-sdk-next-16 Ready Ready Preview, Comment, Open in v0 May 28, 2026 6:39am
flags-sdk-snippets Ready Ready Preview, Comment, Open in v0 May 28, 2026 6:39am
flags-sdk-sveltekit-snippets Ready Ready Preview, Comment, Open in v0 May 28, 2026 6:39am
shirt-shop Ready Ready Preview, Comment, Open in v0 May 28, 2026 6:39am
shirt-shop-api Ready Ready Preview, Comment, Open in v0 May 28, 2026 6:39am

Comment thread packages/adapter-vercel/src/index.ts
Comment thread packages/adapter-vercel/src/index.ts
Comment on lines -67 to -69
if (!process.env.FLAGS) {
throw new Error('flags: Missing environment variable FLAGS');
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this always happens outside of the scope of a request, so no OIDC token may be available?

I wonder if there's another way to verify the context we're in, or will be in when this runs, like checking if it's in development so we in theory always have the OIDC token, or in Vercel, where we at least know it'll be there eventually, or somewhere else, where we might require an SDK Key then.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea this is in module scope. What do you want to achieve with the context verification?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess just throwing early to notice when something is configured wrong, but not absolutely needed

Comment thread packages/vercel-flags-core/src/controller/auth.ts
Comment thread packages/vercel-flags-core/src/index.make.ts
@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​react@​19.3.0-canary-f4e0d4ed-202604291001008496100
Addednpm/​@​vercel/​oidc@​3.4.01001008496100

View full report

@github-actions github-actions Bot mentioned this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants