Finished Project - #755
Conversation
🚀 Project Submitted!Thanks for submitting your project! I will review it soon. 📋 Please check the dashboard to make sure the project is marked as Pending. |
|
@AaronjMurphy Project approved! 😄✅ Very elegant and to the point solution. Your code is well organized and user experience is smooth. Oh and you did a few of the challenges too! Well done. 😊 🥋And congratulations!! You got your Green belt!! 🟢 👩🏫Feedback🔍️I can see you validate the menu input. When I press an option that doesn't exist it let's me try again. However there's no message saying the input was wrong. It just silently fails. 🔍️In ChooseSign(), signSelected is always false: The loop only terminates because a valid selection executes return. A simple while (true) would therefore better express what's happening and remove an unnecessary variable. 🔍I'd also consider replacing these parallel lists: with a GameResult model containing Score and TimeTaken. Parallel lists work here, but they depend on both lists always having matching indexes. A model would keep related information together and make it easy to add fields such as difficulty or operation later. 🧐Challenges Review✅ Difficulty levels — Easy, medium, and hard alter the ranges used to generate questions. 🗺️ Suggested next stepI noticed that you already complete our OOP course. I'd highly recommend taking our LINQ Fundamentals course next. LINQ is one of the most important tools in modern C# and becoming comfortable with it will make your code much cleaner and more expressive. 👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁 And do you mind adding a country in your profile as well? The dashboard and leaderboard look neater when there's a flag. If you're not comfortable with that you can submit a random country. ☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂 Overall great work!✋🏻Looking forward to seeing your next projects! |
No description provided.