Skip to content

Finished Project - #755

Closed
AaronjMurphy wants to merge 3 commits into
the-csharp-academy:mainfrom
AaronjMurphy:main
Closed

Finished Project#755
AaronjMurphy wants to merge 3 commits into
the-csharp-academy:mainfrom
AaronjMurphy:main

Conversation

@AaronjMurphy

Copy link
Copy Markdown

No description provided.

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@AaronjMurphy Project approved! 😄✅ Very elegant and to the point solution. Your code is well organized and user experience is smooth. Oh and you did a few of the challenges too! Well done. 😊

🥋And congratulations!! You got your Green belt!! 🟢

👩‍🏫Feedback

🔍️I can see you validate the menu input. When I press an option that doesn't exist it let's me try again. However there's no message saying the input was wrong. It just silently fails.

🔍️In ChooseSign(), signSelected is always false:

bool signSelected = false;

do
{
    ...
} while (signSelected == false);

The loop only terminates because a valid selection executes return. A simple while (true) would therefore better express what's happening and remove an unnecessary variable.

🔍I'd also consider replacing these parallel lists:

List<int> gameScores
List<TimeSpan> listOfTimes

with a GameResult model containing Score and TimeTaken. Parallel lists work here, but they depend on both lists always having matching indexes. A model would keep related information together and make it easy to add fields such as difficulty or operation later.

🧐Challenges Review

✅ Difficulty levels — Easy, medium, and hard alter the ranges used to generate questions.
✅ Timer — Stopwatch tracks completion time, which is also included in the game history.
✅ Random Game — A random operation is selected for every question.
➖ Number of questions — Not attempted; games currently contain a fixed 10 questions.

🗺️ Suggested next step

I noticed that you already complete our OOP course. I'd highly recommend taking our LINQ Fundamentals course next. LINQ is one of the most important tools in modern C# and becoming comfortable with it will make your code much cleaner and more expressive.


👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁 And do you mind adding a country in your profile as well? The dashboard and leaderboard look neater when there's a flag. If you're not comfortable with that you can submit a random country.


☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall great work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants