Skip to content

Editorial: fix description of Environment Record GetBindingValue#3814

Merged
ljharb merged 1 commit intomainfrom
ER-GetBindingValue
Apr 24, 2026
Merged

Editorial: fix description of Environment Record GetBindingValue#3814
ljharb merged 1 commit intomainfrom
ER-GetBindingValue

Conversation

@michaelficarra
Copy link
Copy Markdown
Member

This was probably a copy/paste error from SetMutableBinding.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/3814 and as multiple pages at https://tc39.es/ecma262/pr/3814/multipage .

Copy link
Copy Markdown
Member

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also get rid of the A property named N wording, that makes no sense here. (evidently copied from Object env records where it does make sense preceded by It attempts to set the value of the Environment Record's associated binding object's property whose name is N to the value V.)

@michaelficarra
Copy link
Copy Markdown
Member Author

@linusg Well it's a Global Environment Record, so it is a property of the global object, right?

@linusg
Copy link
Copy Markdown
Member

linusg commented Apr 9, 2026

I would not call bindings in the global environment's [[DeclarativeRecord]] "properties", no.

@michaelficarra
Copy link
Copy Markdown
Member Author

Then should we also change the description for SetMutableBinding which uses the same wording?

@linusg
Copy link
Copy Markdown
Member

linusg commented Apr 9, 2026

Yes - FWIW I'm fine with just s/property/binding/ if you think keeping that sentence makes sense overall.

@michaelficarra michaelficarra requested a review from linusg April 9, 2026 20:15
@nicolo-ribaudo nicolo-ribaudo added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Apr 23, 2026
@ljharb ljharb force-pushed the ER-GetBindingValue branch from 6f4b574 to c276fc1 Compare April 24, 2026 01:55
@ljharb ljharb merged commit c276fc1 into main Apr 24, 2026
11 of 12 checks passed
@ljharb ljharb deleted the ER-GetBindingValue branch April 24, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants