diff --git a/capycli/common/comparable_version.py b/capycli/common/comparable_version.py index 4fbda58..e42c43f 100644 --- a/capycli/common/comparable_version.py +++ b/capycli/common/comparable_version.py @@ -130,7 +130,7 @@ def __eq__(self, other: ComparableVersion | object) -> bool: def __ne__(self, other: ComparableVersion | object) -> bool: """describes not equal to operator(!=)""" if not isinstance(other, self.__class__): - return False + return True try: return self.compare(other) != 0 diff --git a/tests/test_comparable_version.py b/tests/test_comparable_version.py index 912c91a..27fa0ff 100644 --- a/tests/test_comparable_version.py +++ b/tests/test_comparable_version.py @@ -53,3 +53,9 @@ def test_fill_version(self) -> None: version2 = ComparableVersion("3.28") self.assertEqual(version1, version2, "The version should be equal") self.assertEqual(version2, version1, "The version should be equal") + + def test_ne_with_non_comparable_version(self) -> None: + """__ne__ should return True when comparing to a non-ComparableVersion object""" + self.assertTrue(ComparableVersion("1.0") != "1.0") + self.assertTrue(ComparableVersion("1.0") != 42) + self.assertIsNotNone(ComparableVersion("1.0"))