From 19ecb0275943cc3ffb0987c3dfab3a8e5c871ead Mon Sep 17 00:00:00 2001 From: ty221 Date: Sat, 3 Jan 2015 11:25:36 +0100 Subject: [PATCH 1/4] Implemented eMBee idea 45 --- lib/sup/modes/label_search_results_mode.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/sup/modes/label_search_results_mode.rb b/lib/sup/modes/label_search_results_mode.rb index bca51d456..36eca4d65 100644 --- a/lib/sup/modes/label_search_results_mode.rb +++ b/lib/sup/modes/label_search_results_mode.rb @@ -29,7 +29,9 @@ def self.spawn_nicely label when :inbox BufferManager.raise_to_front InboxMode.instance.buffer else - b, new = BufferManager.spawn_unless_exists("All threads with label '#{label}'") { LabelSearchResultsMode.new [label] } + unread = (label == :unread)? total : Index.num_results_for(:labels => [label, :unread]) + allmsg = Index.num_results_for(:labels => [label]) + b, new = BufferManager.spawn_unless_exists("All threads with label '#{label}' - #{allmsg.pluralize 'message'}, #{unread} unread") { LabelSearchResultsMode.new [label] } b.mode.load_threads :num => b.content_height if new end end From 8cdb97120f59a79454ea10694fc8dde5f32753d8 Mon Sep 17 00:00:00 2001 From: ty221 Date: Sun, 4 Jan 2015 09:43:11 +0100 Subject: [PATCH 2/4] Fixed mistake in countting --- lib/sup/modes/label_search_results_mode.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sup/modes/label_search_results_mode.rb b/lib/sup/modes/label_search_results_mode.rb index 36eca4d65..c3a2838b2 100644 --- a/lib/sup/modes/label_search_results_mode.rb +++ b/lib/sup/modes/label_search_results_mode.rb @@ -29,7 +29,7 @@ def self.spawn_nicely label when :inbox BufferManager.raise_to_front InboxMode.instance.buffer else - unread = (label == :unread)? total : Index.num_results_for(:labels => [label, :unread]) + unread = Index.num_results_for(:labels => [label, :unread]) allmsg = Index.num_results_for(:labels => [label]) b, new = BufferManager.spawn_unless_exists("All threads with label '#{label}' - #{allmsg.pluralize 'message'}, #{unread} unread") { LabelSearchResultsMode.new [label] } b.mode.load_threads :num => b.content_height if new From ecdcc9ca6ee184baf92eb082e3952025e425685d Mon Sep 17 00:00:00 2001 From: ty221 Date: Sun, 18 Jan 2015 13:10:08 +0100 Subject: [PATCH 3/4] Made statusbar more compact, by removing some unnecessary content --- lib/sup/modes/label_search_results_mode.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sup/modes/label_search_results_mode.rb b/lib/sup/modes/label_search_results_mode.rb index c3a2838b2..00b41f854 100644 --- a/lib/sup/modes/label_search_results_mode.rb +++ b/lib/sup/modes/label_search_results_mode.rb @@ -31,7 +31,7 @@ def self.spawn_nicely label else unread = Index.num_results_for(:labels => [label, :unread]) allmsg = Index.num_results_for(:labels => [label]) - b, new = BufferManager.spawn_unless_exists("All threads with label '#{label}' - #{allmsg.pluralize 'message'}, #{unread} unread") { LabelSearchResultsMode.new [label] } + b, new = BufferManager.spawn_unless_exists("'#{label}' - #{allmsg.pluralize 'message'}, #{unread} unread") { LabelSearchResultsMode.new [label] } b.mode.load_threads :num => b.content_height if new end end From 7bbcf1de147a00deeb7d551708bdb584ad6fa148 Mon Sep 17 00:00:00 2001 From: ty221 Date: Sat, 27 Dec 2014 10:49:09 +0100 Subject: [PATCH 4/4] Improved accuracy of message As written there: https://factor.cc/pad/p/sup-ideas using "loaded" instead of "found" is more accurate, because if something isn't found,that doesn't mean it doesn't exist. --- lib/sup/modes/thread_index_mode.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sup/modes/thread_index_mode.rb b/lib/sup/modes/thread_index_mode.rb index 71d3fed64..3f0b2e494 100644 --- a/lib/sup/modes/thread_index_mode.rb +++ b/lib/sup/modes/thread_index_mode.rb @@ -730,7 +730,7 @@ def load_threads opts={} opts[:when_done].call(num) if opts[:when_done] if num > 0 - BufferManager.flash "Found #{num.pluralize 'thread'}." + BufferManager.flash "Loaded #{num.pluralize 'thread'}." else BufferManager.flash "No matches." end