Repository navigation
Hide an explicitly unset logo name in the sidebar - #233
Open
ketpatil77 wants to merge 3 commits into
Open
ketpatil77 wants to merge 3 commits into
ketpatil77 wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216.
An explicit logo_name=None is converted to the visible text "None" by the sidebar template. Skip the custom-name heading when the option is None, retaining the existing boolean/string switches and custom names.
Added three unittest methods covering None, six boolean/string forms and a custom name. The None case fails before this change and passes afterward. Run these regressions in the existing Sphinx-version CI matrix; Jinja is already provided by Sphinx. All tests and a warnings-as-errors documentation build pass on Python 3.11/Sphinx 7.4.7. git diff --check passes.
AI assistance: OpenAI Codex helped prepare and validate this change under the contributor's supervision.
CI follow-up: this branch also includes the small Read the Docs configuration repair shared with #232. The service reported config:sphinx:missing-config; explicitly selecting the existing docs/conf.py fixes that prerequisite without changing documentation content. The same path passed a local warnings-as-errors Sphinx build.