Fix/timestamps#256
Merged
Merged
Conversation
all 2026 EVM nodes return `blockTimestamp` inside logs payload for both `eth_getLogs` and `eth_getTransactionReceipt`; still, ethers doesn't include it in those returned objects; we fix this by hooking into some methods which get access to the raw payloads of those requests, and caching the result in Chain.getBlockTimestamp; see ethers-io/ethers.js#5104 Also, fix some caches, as micro-memoize's maxSize default=1
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
10e04cd to
c53d7b9
Compare
Coverage Report |
Farber98
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 2026 EVM nodes return
blockTimestampinside logs payload for botheth_getLogsandeth_getTransactionReceipt;Still, ethers doesn't include it in those returned objects, requiring us to do an extra RPC roundtrip to fetch those.
We fix this by hooking into some Provider methods which get access to the raw payloads of those requests, and caching the result in Chain.getBlockTimestamp; see ethers-io/ethers.js#5104
Also, fix some caches, as micro-memoize's maxSize default=1