You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/Whats-New.md
+12-1Lines changed: 12 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -34,10 +34,21 @@ Several code quality improvements and bug fixes in the AWS SCIM client:
34
34
35
35
Applied Go 1.26 best practices across the codebase:
36
36
37
-
***Removed `github.com/pkg/errors` dependency:** Replaced all `errors.Wrap` and `errors.Errorf` with stdlib `fmt.Errorf` (with `%w`) and `errors.New` in `internal/setup`, `internal/repository`, and `pkg/aws`.
37
+
***Removed `github.com/pkg/errors` dependency:** Replaced all `errors.Wrap` and `errors.Errorf` with stdlib `fmt.Errorf` (with `%w`) and `errors.New` in `internal/setup`, `internal/repository`, `pkg/aws`, and `cmd/idpscim`.
38
38
***`errors.AsType[T]`:** Migrated `errors.As` calls to the generic `errors.AsType[T]` in `internal/core/sync.go` for type safety and performance.
39
39
***Fixed `os.Exit` in `Hash()`:**`internal/model.Hash()` no longer calls `os.Exit(1)` on nil input or encoding failure. It panics instead (appropriate for programming errors, recoverable, produces stack trace).
40
40
41
+
### CLI Modernization (`idpscimcli`)
42
+
43
+
Improved the `idpscimcli` command-line tool for code quality and testability:
44
+
45
+
***Fixed logger initialization bug:** Log handler options were applied after the handler was created, so log level and format from config had no effect. Fixed by configuring options before creating the handler.
46
+
***Testable error handling:**`getGWSDirectoryService` now returns errors instead of calling `os.Exit(1)`, allowing proper error propagation and unit testing.
47
+
***`show()` error handling:** The output function now returns errors instead of silently discarding marshal failures.
Copy file name to clipboardExpand all lines: docs/idpscimcli.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,8 +1,8 @@
1
1
# idpscimcli
2
2
3
-
This is is a `command-line tool` to check and validate some functionalities implemented in idpscim.
3
+
This is a `command-line tool` to check and validate some functionalities implemented in idpscim.
4
4
5
-
The Idea of this tools is check the configuration you will implement in the [idpscim](idpscim.md) program, like the `filter` used for `Google Workspace Groups` and `Users` and the inventory of users and goups in both sides.
5
+
The idea of this tool is to check the configuration you will implement in the [idpscim](idpscim.md) program, like the `filter` used for `Google Workspace Groups` and `Users` and the inventory of users and groups in both sides.
6
6
7
7
## idpscimcli --help
8
8
@@ -48,7 +48,7 @@ Use "idpscimcli [command] --help" for more information about a command.
48
48
49
49
## Building the project
50
50
51
-
To build the project in local, you will need to have installed and configured at least the following:
51
+
To build the project locally, you will need to have installed and configured at least the following:
0 commit comments