Skip to content

Commit f6b51e8

Browse files
committed
fix: propagate opener errors in tryOpen instead of silently dropping them
1 parent 7e71520 commit f6b51e8

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

pkg/open/open.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,9 @@ func tryOpen(ctx context.Context, url string, fn func(string) error, log log.Log
8181
return nil
8282
case <-time.After(time.Second):
8383
}
84-
_ = fn(url)
84+
if err := fn(url); err != nil {
85+
return fmt.Errorf("open url: %w", err)
86+
}
8587
log.WithFields(logrus.Fields{
8688
"url": url,
8789
}).Done("opened url")

0 commit comments

Comments
 (0)