fix: address code review findings in git-ssh-signature command

- Rename unused cobraCmd parameter to _ in RunE closure
- Remove os.Args[1:] from buffer-file-missing error message
- Add nil guard in delegateToSSHKeygen when git-ssh-signature not found in os.Args

Author: skevetter

cmd/agent/git_ssh_signature.go

@@ -42,7 +42,7 @@ func NewGitSSHSignatureCmd(flags *flags.GlobalFlags) *cobra.Command {
 		FParseErrWhitelist: cobra.FParseErrWhitelist{
 			UnknownFlags: true,
 		},
-		RunE: func(cobraCmd *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, args []string) error {
 			logger := log.GetInstance()
 
 			// For non-sign operations (verify, find-principals, check-novalidate),
@@ -54,8 +54,8 @@ func NewGitSSHSignatureCmd(flags *flags.GlobalFlags) *cobra.Command {
 			// Sign operation requires a buffer file
 			if len(args) < 1 {
 				return fmt.Errorf(
-					"buffer file is required (received %d positional args: %v, flags: %v)",
-					len(args), args, os.Args[1:],
+					"buffer file is required (received %d positional args: %v)",
+					len(args), args,
 				)
 			}
 
@@ -91,6 +91,9 @@ func delegateToSSHKeygen(logger log.Logger) error {
 			break
 		}
 	}
+	if sshArgs == nil {
+		return fmt.Errorf("git-ssh-signature not found in process arguments")
+	}
 
 	logger.Debugf("delegating to ssh-keygen: %s %v", sshKeygen, sshArgs)