refactor(examples): rename large data set example - #810
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the “10k Rows” basic example to be consistently named “Large Data Set” across the Angular example app, updating the component identifier as well as the navigation and routing metadata.
Changes:
- Renames the example component selector and class to “Large Data Set”.
- Updates the sidebar navigation entry to the new route/name.
- Updates the router configuration (path, title, sourcePath, and lazy-load import) to the new identifiers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/app/basic/large-data-set.component.ts | Renames the standalone component selector and exported class to match “Large Data Set”. |
| src/app/app.component.html | Updates the “Basic” navigation link to the new route and display name. |
| src/app/app-routing.module.ts | Updates the route path and route data to “large-data-set” and points lazy-loading to the renamed export. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fh1ch
approved these changes
Aug 25, 2026
fh1ch
left a comment
fh1ch
left a comment
Member
There was a problem hiding this comment.
@spike-rabbit flawless work, much better 🙇
LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The basic example is named "10k Rows" in its component file, selector, route, navigation, and route metadata.
What is the new behavior?
The example is consistently named "Large Data Set" across its component file and class, selector, route, navigation entry, and source metadata.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: