Skip to content

fix: bring native popover to top layer for special cases - #2622

Merged
spike-rabbit merged 2 commits into
mainfrom
fix/popover-layering
Aug 27, 2026
Merged

fix: bring native popover to top layer for special cases#2622
spike-rabbit merged 2 commits into
mainfrom
fix/popover-layering

Conversation

@dr-itz

@dr-itz dr-itz commented Aug 25, 2026

Copy link
Copy Markdown
Member

@dr-itz
dr-itz force-pushed the fix/popover-layering branch 2 times, most recently from ba3f219 to 404f10d Compare August 26, 2026 06:59
@dr-itz
dr-itz force-pushed the fix/popover-layering branch from 404f10d to 54d2a36 Compare August 26, 2026 11:03
@dr-itz

dr-itz commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

@spike-rabbit WDYT?

In case there are toast and a full-screen modal is opened, it will be in front of the toasts until another toast is displayed. I think this behaviour is actually good or at least better than what we have now (not showing the toast at all).

This would also need a v49 backport

@spike-rabbit

Copy link
Copy Markdown
Member

I guess for now we don't have any choice.
What about we request a feature for the CDK the brings an alternative for the z-index base stacking.
So the cdk itself brings overlays in the correct order? Something like a priority config or so.

@dr-itz

dr-itz commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

I guess for now we don't have any choice. What about we request a feature for the CDK the brings an alternative for the z-index base stacking. So the cdk itself brings overlays in the correct order? Something like a priority config or so.

since the z-index based stacking is our own (disgusting) hack, from a CDK POV there's no change in using popover. Basically stacking is always in order of opening the overlay. And with popover API it's the same. And there is now way to change stacking order with the popover API.

@dr-itz
dr-itz marked this pull request as ready for review August 26, 2026 13:51
@dr-itz
dr-itz requested review from a team as code owners August 26, 2026 13:51

@spike-rabbit spike-rabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spike-rabbit spike-rabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add you add a test for this?
e2e is also fine if needed

@dr-itz
dr-itz force-pushed the fix/popover-layering branch from 51c9634 to 270f7a7 Compare August 26, 2026 15:17
@dr-itz
dr-itz requested a review from spike-rabbit August 26, 2026 15:43
Comment thread playwright/e2e/element-examples/si-modal-service.spec.ts
@spike-rabbit
spike-rabbit added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit f001ab9 Aug 27, 2026
15 of 18 checks passed
@spike-rabbit
spike-rabbit deleted the fix/popover-layering branch August 27, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants