From 64143e621c66fd12492cf71f212c29972d4f5cc2 Mon Sep 17 00:00:00 2001 From: Roman Sharkov Date: Wed, 2 Sep 2026 16:18:12 +0200 Subject: [PATCH] ci: Disable benchmarking in CI --- acceptance/router_benchmark/BUILD.bazel | 4 ++++ doc/dev/testing/benchmarking.rst | 14 ++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/acceptance/router_benchmark/BUILD.bazel b/acceptance/router_benchmark/BUILD.bazel index 21f3f853da..77ed12305d 100644 --- a/acceptance/router_benchmark/BUILD.bazel +++ b/acceptance/router_benchmark/BUILD.bazel @@ -32,6 +32,9 @@ data = [ "//tools/mmbm:mmbm", ] +# The router benchmark is excluded from CI. CI agents are shared, virtualized machines, +# so the throughput they measure says little about the router. +# Performance regression testing is scheduled on baremetal instead. raw_test( name = "test", src = "test.py", @@ -40,6 +43,7 @@ raw_test( homedir = "$(rootpath //docker:router.tarball)", # This test uses sudo and accesses /var/run/netns. local = True, + tags = ["manual"], deps = ["benchmarklib"], ) diff --git a/doc/dev/testing/benchmarking.rst b/doc/dev/testing/benchmarking.rst index c3460edd7b..36be571c67 100644 --- a/doc/dev/testing/benchmarking.rst +++ b/doc/dev/testing/benchmarking.rst @@ -25,3 +25,17 @@ results available for pickup by :program:`benchmark.py`. Otherwise these operations still have to be carried out manually. The :program:`mmbm` and :program:`coremark` tools can be found in: ``bazel-bin/tools/mmbm/mmbm_/mmbm`` and ``bazel-bin/tools/coremark/coremark``. + +Router benchmark acceptance test +================================ + +The benchmark harness is also wrapped in a Bazel test that sets up a local topology and +benchmarks the router in it: + +.. code-block:: sh + + bazel test --test_output=streamed //acceptance/router_benchmark:test + +This test is tagged ``manual``. It is not part of the CI build nor of ``//...`` wildcards. +CI agents are shared, virtualized machines, so the throughput they measure says little +about the router. Performance regression testing is scheduled on baremetal instead.