Make installer code more clear

I always found the `resolve_if_necessary` method pretty confusing
because by reading it, it suggests that resolution always happens, and
the point is whether that needs to be local or remote. This commit tries
to make that more clear.

Author: deivid-rodriguez

bundler/lib/bundler/definition.rb

@@ -176,6 +176,24 @@ def check!
       resolve
     end
 
+    #
+    # Setup sources according to the given options and the state of the
+    # definition.
+    #
+    # @return [Boolean] Whether fetching remote information will be necessary or not
+    #
+    def setup_domain!(options)
+      prefer_local! if options[:"prefer-local"]
+
+      if options[:local] || (no_resolve_needed? && !missing_specs?)
+        with_cache!
+        false
+      else
+        remotely!
+        true
+      end
+    end
+
     def resolve_with_cache!
       with_cache!
 

bundler/lib/bundler/installer.rb

@@ -77,7 +77,7 @@ def run(options)
           return
         end
 
-        if resolve_if_needed(options)
+        if @definition.setup_domain!(options)
           ensure_specs_are_compatible!
           Bundler.load_plugins(@definition)
           options.delete(:jobs)
@@ -229,19 +229,6 @@ def ensure_specs_are_compatible!
       end
     end
 
-    # returns whether or not a re-resolve was needed
-    def resolve_if_needed(options)
-      @definition.prefer_local! if options[:"prefer-local"]
-
-      if options[:local] || (@definition.no_resolve_needed? && !@definition.missing_specs?)
-        @definition.with_cache!
-        false
-      else
-        @definition.remotely!
-        true
-      end
-    end
-
     def lock
       @definition.lock
     end