Skip to content

Commit f104a42

Browse files
committed
fix loading roms
1 parent 12bbd46 commit f104a42

File tree

6 files changed

+10
-7
lines changed

6 files changed

+10
-7
lines changed

backend/endpoints/responses/rom.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,6 @@ class RomSchema(BaseModel):
309309
rom_user: RomUserSchema
310310
merged_screenshots: list[str]
311311
merged_ra_metadata: RomRAMetadata | None
312-
walkthroughs: list[WalkthroughSchema]
313312

314313
class Config:
315314
from_attributes = True
@@ -405,6 +404,7 @@ class DetailedRomSchema(RomSchema):
405404
user_screenshots: list[ScreenshotSchema]
406405
user_collections: list[UserCollectionSchema]
407406
all_user_notes: list[UserNoteSchema]
407+
walkthroughs: list[WalkthroughSchema]
408408

409409
@classmethod
410410
def from_orm_with_request(cls, db_rom: Rom, request: Request) -> DetailedRomSchema:

backend/models/rom.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,8 +264,8 @@ class Rom(BaseModel):
264264
lazy="raise", back_populates="rom"
265265
)
266266
rom_users: Mapped[list[RomUser]] = relationship(lazy="raise", back_populates="rom")
267-
walkthroughs: Mapped[list["Walkthrough"]] = relationship(
268-
"Walkthrough", lazy="raise", back_populates="rom", cascade="all, delete-orphan"
267+
walkthroughs: Mapped[list[Walkthrough]] = relationship(
268+
lazy="raise", back_populates="rom", cascade="all, delete-orphan"
269269
)
270270
notes: Mapped[list[RomNote]] = relationship(lazy="raise", back_populates="rom")
271271
metadatum: Mapped[RomMetadata] = relationship(

backend/models/walkthrough.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
11
from __future__ import annotations
22

3+
from typing import TYPE_CHECKING
4+
35
from sqlalchemy import Enum, ForeignKey, Integer, String, Text
46
from sqlalchemy.dialects import mysql
57
from sqlalchemy.orm import Mapped, mapped_column, relationship
68

79
from handler.walkthrough_handler import WalkthroughFormat, WalkthroughSource
810
from models.base import BaseModel
911

12+
if TYPE_CHECKING:
13+
from models.rom import Rom
14+
1015

1116
class Walkthrough(BaseModel):
1217
__tablename__ = "walkthroughs"

frontend/src/__generated__/models/DetailedRomSchema.ts

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frontend/src/__generated__/models/RomFileCategory.ts

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frontend/src/__generated__/models/SimpleRomSchema.ts

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)