diagnostics (errors) aren't working very well

[robb-j]

They only seem to show when a document is first opened then they don't get updated after the document is edited.

[robb-j]

Glancing through the LSP logs there doesn't seem to be any textDocument/publishDiagnostics happening

[robb-j]

Docs https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_publishDiagnostics

[robb-j]

Notes from debugging:

I've got a repro to show the server isn't sending updated textDocument/publishDiagnostics notifications and a screencast of it happening (attached)

lsp.log

Screen.Recording.2023-04-09.at.19.43.33.mov

[robb-j]

Improved repro

lsp.log

Screen.Recording.2023-04-09.at.21.48.43.mov

[robb-j]

eclipse-lemminx/lemminx#1509