Merge pull request #3129 from rmosolgo/fix-deeply-nested-queries-again

Make sure stack error comes back in response

Author: Robert Mosolgo

lib/graphql/schema.rb

@@ -1117,7 +1117,7 @@ def possible_types(type = nil, context = GraphQL::Query::NullContext)
               next true unless type.kind.interface?
               next true unless possible_type.kind.object?
 
-              # Use `.graphql_name` comparison to match legacy vs class-based types. 
+              # Use `.graphql_name` comparison to match legacy vs class-based types.
               # When we don't need to support legacy `.define` types, use `.include?(type)` instead.
               possible_type.interfaces(context).any? { |interface| interface.graphql_name == type.graphql_name }
             end if stored_possible_types
@@ -1673,7 +1673,7 @@ def add_subscription_extension_if_necessary
       end
 
       def query_stack_error(query, err)
-        query.analysis_errors.push(GraphQL::AnalysisError.new("This query is too large to execute."))
+        query.context.errors.push(GraphQL::ExecutionError.new("This query is too large to execute."))
       end
 
       private

spec/graphql/analysis/ast/max_query_depth_spec.rb

@@ -144,7 +144,11 @@
     }
 
     it "returns an error" do
-      assert_equal ["This query is too large to execute."], query.static_errors.map(&:message)
+      assert_equal ["This query is too large to execute."], query.result["errors"].map { |err| err["message"] }
+
+      # Make sure `Schema.execute` works too
+      execute_result = schema.execute(query_string)
+      assert_equal ["This query is too large to execute."], execute_result["errors"].map { |err| err["message"] }
     end
   end
 end