Skip to content

Bump grove version to v1.8.0#207

Open
amyfbrown wants to merge 1 commit into
rigetti:masterfrom
amyfbrown:v1.8
Open

Bump grove version to v1.8.0#207
amyfbrown wants to merge 1 commit into
rigetti:masterfrom
amyfbrown:v1.8

Conversation

@amyfbrown

@amyfbrown amyfbrown commented Apr 29, 2019

Copy link
Copy Markdown
Contributor

Bump the grove version to a new v1.x value so that pip install quantum-grove gives users a version that's pyQuil 2.0 compatible.

@amyfbrown amyfbrown self-assigned this Apr 29, 2019
@msohaibalam

Copy link
Copy Markdown

Would it be a problem that we're bumping the version down in this case?

@amyfbrown

Copy link
Copy Markdown
Contributor Author

@msohaibalam, I agree that it's odd to go from v2.0.0b0 to v1.x. Can we delete the v2.0.0b0 pre-release tag and proceed with the v1.x tag? If not, we could consider releasing v2.0.0 without a beta flag in the patch version. The changes are backwards-incompatible, so it might make more sense to bump the major version number.

@notmgsk

notmgsk commented Jul 10, 2019

Copy link
Copy Markdown

I don't think it should matter than we're changing the version down from v2.0.0b0 since that tag is not seen by pip or conda (as far as I can tell).

@amyfbrown

Copy link
Copy Markdown
Contributor Author

@notmgsk

notmgsk commented Jul 10, 2019

Copy link
Copy Markdown

@notmgsk, it looks like 2.0.0b0 is listed as a pre-release on pypi.

Even so, does it really matter? Pre-release should roughly mean "don't depend on this"

@notmgsk notmgsk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring the semaphore weirdness. LG2M.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants