Added status filter#80
Open
ruiiiijiiiiang wants to merge 2 commits intorgwood:masterfrom
Open
Conversation
Owner
|
Thanks for this! I may take a while to review it because this is a very busy time in my personal life, but at a first glance this looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added status filter as a popup menu. The systemd service states turned out to be a bigger rabbit hole than I anticipated. I played around with a lot of different ideas on what should be used as filters, and I landed on these 8 that I believe to be the most meaningful:
Active,
Inactive,
Failed,
Enabled,
Disabled,
Masked,
Loaded,
Unloaded,
The list is definitely not exhaustive, but it covers my use cases pretty well. I'd love to hear different ideas and I'm happy to discuss how this implementation can be tweaked.