Skip to content

GET api/v1/notifications is not idempotent #7268

Description

@manuelwedler

Problem Definition

A GET api/v1/notifications request returns only new notifications since the last request to the endpoint. The API deletes all notifications when this endpoint is called.
This is a clear misuse of the HTTP GET method, as it should always be idempotent and should never change resources in the raiden client. It would be better if the endpoint would return all notifications that are currently relevant. Notifications should only be removed if they are not relevant anymore, for example after the user deposits to the UDC the low RDN notification should be removed.

System Description

raiden v2.0.0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions