CLI: Fix TAP compliance for colon in unquoted YAML diag

Cherry-picked from f0af617 (3.0.0-dev).

> When an assertion message contained a colon followed by a space,
> and otherwise is a single line of ASCII characters, we formatted it
> as an unquoted string. This is invalid in YAML 1.2, and thus tap-parser
> would ignore the diagnostic block.
>
> This does not affect the TAP result itself (the test name and failure
> status are separate from this), and it does not affect the QUnit CLI
> output where the information is shown either way.
>
> When passing the CLI output to tap-parser (such as in QTap), it
> silently ignored the "diag" block containing the assertion
> message/actual/expected value, because it is not valid YAML.
>
> Note that YAML 1.2 does allow literal colons and hash tags in unquoted
> strings, when they are not followed by or preceded by a space, but
> I'm keeping our version simpler by erring toward quoted strings when
> these appear. Just because we could squeeze one more edge case with
> plain unquoted strings, doesn't mean we have to. This way keeps our
> format a bit more intuitive by making it predictable and easy to
> deduce why a string is quoted or not, based solely on the chars used
> and not based on obscure YAML internals.
>
> Ref https://yaml.org/spec/1.2.2/#733-plain-style

Author: Krinkle

src/reporters/TapReporter.js

@@ -61,7 +61,10 @@ function prettyYamlValue (value, indent = 2) {
     // cause data loss or invalid YAML syntax.
     //
     // - Quotes, escapes, line breaks, or JSON-like stuff.
-    const rSpecialJson = /['"\\/[{}\]\r\n]/;
+    // - Not allowed in YAML unquoted strings per https://yaml.org/spec/1.2.2/#733-plain-style
+    //   * ": " (colon followed by space)
+    //   * " #" (space followed by hash)
+    const rSpecialJson = /['"\\/[{}\]\r\n|:#]/;
 
     // - Characters that are special at the start of a YAML value
     const rSpecialYaml = /[-?:,[\]{}#&*!|=>'"%@`]/;

test/cli/TapReporter-to-TapParser.js

@@ -118,6 +118,40 @@ QUnit.module('TapReporter-to-TapParser', hooks => {
     });
   });
 
+  QUnit.test('Quoting [colon]', async (assert) => {
+    emitter.emit('runStart');
+    emitter.emit('testEnd', {
+      fullName: ['example'],
+      status: 'failed',
+      runtime: 0,
+      errors: [{
+        message: 'behold: the colon'
+      }]
+    });
+    emitter.emit('runEnd', {
+      testCounts: {
+        total: 1,
+        passed: 0,
+        failed: 1,
+        skipped: 0,
+        todo: 0
+      }
+    });
+
+    assert.propContains(await getParseResult(), {
+      ok: false,
+      failures: [
+        {
+          ok: false,
+          name: 'example',
+          diag: {
+            message: 'behold: the colon'
+          }
+        }
+      ]
+    });
+  });
+
   QUnit.test('Deep equal failure', async (assert) => {
     emitter.emit('runStart');
     emitter.emit('testEnd', {

test/cli/TapReporter.js

@@ -180,7 +180,7 @@ Bail out! Boo
 
     assert.strictEqual(buffer, `not ok 1 global failure
   ---
-  message: ReferenceError: Boo is not defined
+  message: "ReferenceError: Boo is not defined"
   severity: failed
   stack: |
         at Object.<anonymous> (/dev/null/test/unit/data.js:6:5)

test/cli/fixtures/assert-throws-failure.tap.txt

@@ -6,7 +6,7 @@ not ok 1 Throws match > bad
   ---
   message: match error
   severity: failed
-  actual  : Error: Match me with a pattern
+  actual  : "Error: Match me with a pattern"
   expected: "/incorrect pattern/"
   stack: |
         at /qunit/test/cli/fixtures/assert-throws-failure.js:3:12

test/cli/fixtures/callbacks-rejected.tap.txt

@@ -4,7 +4,7 @@
 TAP version 13
 not ok 1 global failure
   ---
-  message: Error: begin
+  message: "Error: begin"
   severity: failed
   stack: |
     Error: begin

test/cli/fixtures/config-noglobals-add.tap.txt

@@ -4,7 +4,7 @@
 TAP version 13
 not ok 1 adds global var
   ---
-  message: Introduced global variable(s): dummyGlobal
+  message: "Introduced global variable(s): dummyGlobal"
   severity: failed
   ...
 1..1

test/cli/fixtures/config-noglobals-remove.tap.txt

@@ -4,7 +4,7 @@
 TAP version 13
 not ok 1 deletes global var
   ---
-  message: Deleted global variable(s): dummyGlobal
+  message: "Deleted global variable(s): dummyGlobal"
   severity: failed
   ...
 1..1

test/cli/fixtures/event-error-memory.tap.txt

@@ -3,7 +3,7 @@
 TAP version 13
 not ok 1 global failure
   ---
-  message: ReferenceError: boom is not defined
+  message: "ReferenceError: boom is not defined"
   severity: failed
   stack: |
     ReferenceError: boom is not defined

test/cli/fixtures/uncaught-error-callbacks-begin.tap.txt

@@ -4,7 +4,7 @@
 TAP version 13
 not ok 1 global failure
   ---
-  message: Error: No dice
+  message: "Error: No dice"
   severity: failed
   stack: |
     Error: No dice

test/cli/fixtures/uncaught-error-callbacks-done.tap.txt

@@ -10,7 +10,7 @@ ok 1 module1 > test1
 # fail 0
 Bail out! Error: No dice
   ---
-  message: Error: No dice
+  message: "Error: No dice"
   severity: failed
   stack: |
     Error: No dice