Fix AES69 reference link#141
Open
JSap0914 wants to merge 1 commit into
Open
Conversation
f-brinkmann
requested changes
Jul 10, 2026
f-brinkmann
left a comment
f-brinkmann
left a comment
Member
There was a problem hiding this comment.
Thanks for reporting the broken link! May I suggest to update rather than to refer to a different page?
Unfortunately the AES homepage is broken and does not list the latest version of the standard atm.
| (https://www.aes.org/publications/standards/search.cfm?docID=99) | ||
| format*, Audio Engineering Society, Inc., New York, NY, USA. Public SOFA and | ||
| AES69 revision information is available at | ||
| <https://www.sofaconventions.org/mediawiki/index.php/SOFA_(Spatially_Oriented_Format_for_Acoustics)>. |
Member
There was a problem hiding this comment.
I would rather update the link to the acual standard
Suggested change
| <https://www.sofaconventions.org/mediawiki/index.php/SOFA_(Spatially_Oriented_Format_for_Acoustics)>. | |
| <https://aes.org/publications/standards-store/?id=99>. |
Referring to sofaconventions would be a little confusing here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #139
Changes proposed in this pull request:
Validation
git diff --checkcurl -L https://www.aes.org/publications/standards/search.cfm?docID=99->404curl -L https://www.sofaconventions.org/mediawiki/index.php/SOFA_(Spatially_Oriented_Format_for_Acoustics)->200UV_PROJECT_ENVIRONMENT=../.venv uv run --project .. --extra docs --extra tests python -m sphinx -b html . _build/htmlfromdocs/-> passedpython -m sphinx -b linkcheck . _build/linkcheckconfirmed the new SOFA conventions URL asok; the command exits nonzero because of pre-existing unrelated broken links in the docs (verification_rules, an old MIDI URL, and generated relative links).Duplicate check
Immediately before opening this PR, searches for
aes.org,docID=99,AES69 link,AES69 reference, anddead linkinpyfar/sofarPRs returned no matching open or closed PRs for this README reference fix.