Skip to content

Content review: content/docs/esc/concepts/providers.md - #21045

Open
pulumi-bot wants to merge 1 commit into
masterfrom
content-review/docs-esc-concepts-providers
Open

Content review: content/docs/esc/concepts/providers.md#21045
pulumi-bot wants to merge 1 commit into
masterfrom
content-review/docs-esc-concepts-providers

Conversation

@pulumi-bot

@pulumi-bot pulumi-bot commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Important

This PR requires a human review decision — auto-merge is NOT armed. Its fixes include judgment-class changes (claim corrections, structural repairs), so approving does not merge it by itself: the PR-review sweep arms auto-merge only after its own gates pass, or a human merges manually.

Why this page

  • Page: content/docs/esc/concepts/providers.md → /docs/esc/concepts/providers/
  • Lane: priority
  • Strategic tier: 2 (no_retire: false)
  • Traffic: 194 monthly visits (period 2026-02-17 to 2026-08-17; source CLICKSTREAM.FCT_PAGEVIEWS)
  • Search: 12 impressions, 0.00% CTR, corpus median 0.70%, period 2026-02-17 to 2026-08-17
  • Last reviewed: never (attempts: 0)
  • Selection score: 26.3869

This section is composed deterministically from the selection queue; do not edit it.

Fixes applied

Claim / finding Authoritative source Correction
Readthrough orphaned-structure (L41): "If no built-in plugin produces the value you need, a custom adapter lets you plug in your own servi…" readthrough coherence pass; content/docs/esc/providers/secrets/external.md Named the capability and linked it: the sentence now points at the external provider, which is the documented escape hatch for plugging in your own service via a custom HTTPS adapter. Local repair only — one sentence, no surrounding prose touched.

Findings not applied

  • Vale filler (L17): Don't start a sentence with 'There is'. — Not stamped deterministic_fix, so there is no exact replacement to apply; rewriting "There is no separate install step" is a prose-quality judgment call for a human. (context: Don't start a sentence with 'There is'.)
  • Sibling page carries the same dead end. content/docs/esc/concepts/rotators.md (L31) ends with the identical unlinked "If no built-in rotator fits, a custom adapter lets you plug in your own service." The parallel fix would be a link to /docs/esc/providers/rotators/external/, but that file is out of this review's editing scope — flagging it for a human or a follow-up sweep.
  • Search opportunity (GSC). 12 impressions at 0.00% CTR over the window, against a 0.70% corpus median. Flag-only: title and meta_desc were not touched. Observation — the title "Providers" and meta description say nothing about the concrete services a reader searches for (AWS, Vault, 1Password), so the page may simply never surface for those queries. Worth a /seo-analyze pass.

The items above are banked for the automated glow-up lane, which executes a page's accumulated deferrals under human review — or run /glow-up content/docs/esc/concepts/providers.md to work them now.

Screenshot check

No images. The page source references no screenshots, diagrams, or other content images (only the generic shared meta_image card, if any), so there is nothing to verify. (Determined from the source; the screenshot pass was skipped.)

Rendered content

Skipped — the page source uses no shortcodes, partials, or includes, so the rendered HTML and markdown carry no content beyond the source prose (nothing data-sourced or partial-included to fact-check). No make build or rendered pass required. (Determined from the source.)

Verification

  • make lint: ✅ make lint re-verified by the workflow on f30aa51
  • Pre-step artifacts:
    • .verified-claims.json: 15 verdict(s); 0 contradicted/mismatch, 0 unverifiable
    • .vale-findings.json: 1 finding(s)
    • .readthrough-findings.json: ran=True, 1 finding(s)
    • .frontmatter-validation.json: 1 file(s); 0 alias collision(s)

@pulumi-bot @claude
Content review: content/docs/esc/concepts/providers.md
f30aa51 
Automated existing-content review.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added review:triaging Claude Triage is currently classifying the PR domain:docs PR touches technical docs review:in-progress Claude review is currently running and removed review:triaging Claude Triage is currently classifying the PR labels Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Pre-merge Review — Last updated 2026-08-21T14:43:36Z

Tip

Summary: This is a single-sentence content fix to the ESC concepts page on providers (content/docs/esc/concepts/providers.md): the closing line of the "two functional categories" section previously said a vague "a custom adapter lets you plug in your own service" with nothing to click, and now names and links the external provider. The wrongness that would block a reader here is a dead end or a wrong pointer — a reader who needs a source ESC doesn't natively support has to be able to find the escape hatch, so the risk is the named capability not matching what that page actually documents, or the link 404ing. Both check out: the link target exists at content/docs/esc/providers/secrets/external.md, and that page describes itself as "a generic escape hatch for integrating secret sources that don't have native Pulumi ESC support" via a custom HTTPS adapter. All 4 extracted claims in the touched lines verified against in-repo sources; a cross-sibling read confirmed the surrounding section's descriptions of login and secrets providers still match their reference pages. No blocking findings.

Review confidence:

Dimension Level Notes
mechanics HIGH
facts HIGH
cross-sibling consistency HIGH
Investigation log
  • Cross-sibling reads: 3 of 11 siblings
  • External claim verification: 4 of 4 claims verified (0 unverifiable, 0 contradicted) · 4 specialists (numerical, cross-reference, capability, framing); 0 cross-specialist corroborations · routed: 0 inline, 4 Pass 1, 0 Pass 2, 0 Pass 3.
  • Cited-claim spot-checks: not run (no cited claims)
  • Frontmatter sweep: ran on body + meta_desc
  • Temporal-trigger sweep: not run (no trigger words)
  • Code execution: not run (no static/programs/ change)
  • Code-examples checks: not run (no fenced code blocks in content files)
  • Editorial-balance pass: not run (not under content/blog/)
🚨 Outstanding ⚠️ Low-confidence 💡 Pre-existing ✅ Resolved
0 0 0 0

🔍 Verification trail

4 claims extracted · 4 verified · 0 unverifiable · 0 contradicted
  • L38 in content/docs/esc/concepts/providers.md "The ESC OIDC setup guide at /docs/esc/guides/configuring-oidc/ describes per-provider trust configuration." → ✅ verified (evidence: The linked guide (/docs/esc/guides/configuring-oidc/) contains a "Configuring trust relationships" section describing claims used per-provider trust policies, and links to per-provider sub-guides (AWS, Azure, GCP, Doppler, Infisical…; source: repo:content/docs/esc/guides/configuring-oidc/_index.md)
  • L38 in content/docs/esc/concepts/providers.md "ESC login providers authenticate to a downstream service and issue short-lived credentials for it, typically through OpenID Connect." → ✅ verified (evidence: The sibling login providers index page states: "Login providers issue short-lived credentials for downstream services... OpenID Connect (OIDC) is the recommended authentication mode wherever supported," and lists providers where most…; source: repo:content/docs/esc/providers/login/_index.md)
  • L39 in content/docs/esc/concepts/providers.md "ESC secrets and configuration providers pull configuration and secrets from an external system of record into your environment at open time." → ✅ verified (evidence: The sibling secrets-providers reference page states: "Secrets and configuration providers dynamically import values from an external system of record into your environment... secrets are fetched at open time, not at definition time,"…; source: repo:content/docs/esc/providers/secrets/_index.md)
  • L41 in content/docs/esc/concepts/providers.md "If no built-in plugin produces the value you need, the external provider lets you plug in your own service through a custom HTTPS adapter." → ✅ verified (evidence: The linked page content/docs/esc/providers/secrets/external.md states: "The external provider serves as a generic escape hatch for integrating secret sources that don't have native Pulumi ESC support. Instead of waiting for a native…; source: repo:content/docs/esc/providers/secrets/external.md)

🚨 Outstanding in this PR

No outstanding findings in this PR.

⚠️ Low-confidence

No low-confidence findings.

💡 Pre-existing issues in touched files (optional)

No pre-existing issues in touched files.

✅ Resolved since last review

No items resolved since the last review.

📜 Review history

  • 2026-08-21T14:43:36Z — Reviewed the one-sentence external provider link fix on the ESC providers concept page; link target and capability description both confirmed, all 4 claims verified, no blocking findings. (f30aa51)
  • Refresh this review — comment @claude #update-review. Say what you fixed, or which finding you dispute and why; both work in the same mention.
  • Ask for anything else — comment @claude with no hashtag (questions, one-off fixes). Leaves this review untouched.

Important

Please don't hide, resolve, or delete this comment! It breaks things!

📖 How pre-merge review works — the full lifecycle, short-circuits, and escape hatches.

@github-actions github-actions Bot added review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:in-progress Claude review is currently running labels Aug 21, 2026
@pulumi-bot

pulumi-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

Your site preview for commit f30aa51 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-21045-f30aa510.s3-website.us-west-2.amazonaws.com

Changed pages:

CamSoper
CamSoper approved these changes Aug 21, 2026
View reviewed changes

@CamSoper CamSoper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated rubber stamp approval applied :shipit: -- What is this?

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CamSoper CamSoper CamSoper approved these changes

Assignees

No one assigned

Labels

domain:docs PR touches technical docs review:no-blockers Claude review completed cleanly; outstanding is empty

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pulumi-bot @CamSoper