Repository navigation
sysfs: skip cooling devices whose attributes return ENODATA - #886
Merged
SuperQ merged 2 commits intoOct 19, 2026
Merged
Conversation
Signed-off-by: Joe LaPenna <jlapenna@gmail.com>
SuperQ
reviewed
Oct 18, 2026
SuperQ
requested changes
Oct 18, 2026
Signed-off-by: Joe LaPenna <jlapenna@gmail.com>
Contributor
Author
|
@SuperQ both review points are addressed in 510cc3d:
Both threads are resolved. Could you take another look when you have a moment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cooling-device attribute returning
ENODATAcurrently fails the whole thermal collection. Adderrors.Is(err, syscall.ENODATA)to the shared sysfscanIgnoreErrorpolicy so callers can skip unavailable entries. Other I/O and parse errors still propagate.The maintainer follow-up removes the parser-function indirection from cooling-device collection and restores its direct parser call. Regression cases exercise the shared predicate with direct,
os.PathErrorand further wrappedENODATA, plusEIO, parse and existing ignorable errors. The original cooling-device fixture remains.Validation at exact
510cc3de5d5de8cba90d697a10f21635dc73bb10: the old shared predicate fails all three ENODATA cases; corrected focused tests and normalmake test(go test -race -p=1 ./...) pass in all 13 test-bearing packages. Affected-packagemake lint pkgs=./sysfsreports zero issues;make style,make check_license, fixture setup and unchangedfixtures.ttarchecks pass. Normal signed-off commit and forward push completed. Current upstream CI and maintainer review remain separate gates.Related: jlapenna/homelab#2631. This change does not deploy a node-exporter package.