From 276603fd833c9fae418f658473a56a334b1942ca Mon Sep 17 00:00:00 2001 From: mbressy Date: Wed, 8 Apr 2026 08:04:55 +0000 Subject: [PATCH 1/3] fix: handle group assignment on uninstall templates --- inc/uninstall.class.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/inc/uninstall.class.php b/inc/uninstall.class.php index cac884c..baa02fe 100644 --- a/inc/uninstall.class.php +++ b/inc/uninstall.class.php @@ -213,7 +213,8 @@ private static function doOneUninstall(PluginUninstallModel $model, Transfer $tr } } - if ($item->isField('groups_id')) { + $can_update_groups = $item->isField('groups_id') || method_exists($item, 'prepareGroupFields'); + if ($can_update_groups) { $nbgroup = countElementsInTableForEntity( "glpi_groups", $entity, From f0ceec077feca7c000fafbf8e823ee66ac01119a Mon Sep 17 00:00:00 2001 From: mbressy Date: Wed, 8 Apr 2026 12:28:36 +0000 Subject: [PATCH 2/3] use AssignableItemInterface --- inc/uninstall.class.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/inc/uninstall.class.php b/inc/uninstall.class.php index baa02fe..3b48e7a 100644 --- a/inc/uninstall.class.php +++ b/inc/uninstall.class.php @@ -29,6 +29,7 @@ */ use Glpi\Asset\Asset_PeripheralAsset; +use Glpi\Features\AssignableItemInterface; use function Safe\preg_grep; @@ -213,8 +214,10 @@ private static function doOneUninstall(PluginUninstallModel $model, Transfer $tr } } - $can_update_groups = $item->isField('groups_id') || method_exists($item, 'prepareGroupFields'); - if ($can_update_groups) { + if ( + $item->isField('groups_id') + || ($item instanceof AssignableItemInterface) + ) { $nbgroup = countElementsInTableForEntity( "glpi_groups", $entity, From d1cc5a557a2970a77d754da0de4ceff65a157e07 Mon Sep 17 00:00:00 2001 From: mbressy Date: Mon, 13 Apr 2026 13:30:21 +0000 Subject: [PATCH 3/3] update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ab27e6d..faaa91f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ### Fixed - Fix locales encoding +- Fix group assignment when applying uninstall templates on assignable items ## [2.10.3] - 2025-11-25