Fix community editon migrations (#5307)

* Fix migration that was not working

cc @macobo

* Fixup old migrations to use `community_edition?` predicate

* Move hourly api request limit migration to the bottom

The odds are low that self-hosters use that one, but let's
make sure it runs after teams have been migrated.

* Tag dump plans as ee only

Author: aerosol

priv/ingest_repo/migrations/20230509124919_clean_up_old_tables_after_v2_migration.exs

@@ -1,10 +1,10 @@
 defmodule Plausible.IngestRepo.Migrations.CleanUpOldTablesAfterV2Migration do
   use Ecto.Migration
 
-  def change do
-    selfhost? = Application.fetch_env!(:plausible, :is_selfhost)
+  import Plausible.MigrationUtils
 
-    unless selfhost? do
+  def change do
+    unless community_edition?() do
       drop_if_exists table(:events)
       drop_if_exists table(:sessions)
     end

priv/repo/migrations/20231121131602_create_plans_table.exs

@@ -1,8 +1,10 @@
 defmodule Plausible.Repo.Migrations.CreatePlansTable do
   use Ecto.Migration
 
+  import Plausible.MigrationUtils
+
   def change do
-    if !Application.get_env(:plausible, :is_selfhost) do
+    if enterprise_edition?() do
       create table(:plans) do
         add :generation, :integer, null: false
         add :kind, :string, null: false

priv/repo/migrations/20231208125624_add_data_retention_in_years_to_plans.exs

@@ -1,8 +1,10 @@
 defmodule Plausible.Repo.Migrations.AddDataRetentionInYearsToPlans do
   use Ecto.Migration
 
+  import Plausible.MigrationUtils
+
   def change do
-    if !Application.get_env(:plausible, :is_selfhost) do
+    if enterprise_edition?() do
       alter table(:plans) do
         add :data_retention_in_years, :integer, null: true
       end

priv/repo/migrations/20250318131615_site_legacy_time_on_page_cutoff.exs

@@ -2,18 +2,22 @@ defmodule Plausible.Repo.Migrations.SiteLegacyTimeOnPageCutoff do
   use Ecto.Migration
   use Plausible
 
+  import Plausible.MigrationUtils
+
   def change do
     alter table(:sites) do
       # New sites will have new time-on-page enabled by default.
       add :legacy_time_on_page_cutoff, :date,
         default: fragment("to_date('1970-01-01', 'YYYY-MM-DD')")
     end
 
-    if Application.get_env(:plausible, :is_selfhost) do
+    if community_edition?() do
       # On self-hosted, new time-on-page will be populated during first deploy.
       execute(
         fn ->
-          repo().query!("UPDATE sites SET legacy_time_on_page_cutoff = ?", [Date.utc_today()])
+          repo().query!("UPDATE sites SET legacy_time_on_page_cutoff = $1::date", [
+            Date.utc_today()
+          ])
         end,
         &pass/0
       )

…kfill_teams_hourly_api_request_limit.exs …kfill_teams_hourly_api_request_limit.exspriv/repo/migrations/20250403093826_backfill_teams_hourly_api_request_limit.exs renamed to priv/repo/migrations/20250403093829_backfill_teams_hourly_api_request_limit.exs priv/repo/migrations/20250403093826_backfill_teams_hourly_api_request_limit.exs renamed to priv/repo/migrations/20250403093829_backfill_teams_hourly_api_request_limit.exs

@@ -30,6 +30,7 @@ defmodule Plausible.ReleaseTest do
     end
   end
 
+  @tag :ee_only
   test "dump_plans/0 inserts plans" do
     stdout =
       capture_io(fn ->