revert: remove log_duration flag now that #23251 fixed the root cause

PR #23251 fixed the "Scheduling:" workunit being promoted to INFO,
so the log_duration mechanism to suppress duplicate durations is no
longer needed. Duration is now shown unconditionally for completed
and canceled workunits.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: Jason Barnett

src/rust/engine/src/nodes/mod.rs

@@ -493,14 +493,12 @@ impl Node for NodeKey {
             NodeKey::Task(task) => Some(&task.params),
             _ => None,
         };
-        let log_duration = !matches!(self, NodeKey::ExecuteProcess(..));
         let context2 = context.clone();
 
         in_workunit!(
             workunit_name,
             self.workunit_level(),
             desc = workunit_desc.clone(),
-            log_duration = log_duration,
             user_metadata = {
                 if let Some(params) = maybe_params {
                     Python::attach(|py| {

src/rust/workunit_store/src/lib.rs

@@ -275,20 +275,16 @@ impl Workunit {
             self.name
         };
 
-        let duration_suffix: Option<String> = if metadata.log_duration {
-            match &self.state {
-                WorkunitState::Completed { time_span } => Some(format!(
-                    " ({})",
-                    format_workunit_duration(Duration::from(time_span.duration))
-                )),
-                WorkunitState::Started { start_time, .. } if canceled => Some(format!(
-                    " ({})",
-                    format_workunit_duration(start_time.elapsed().unwrap_or_default())
-                )),
-                _ => None,
-            }
-        } else {
-            None
+        let duration_suffix: Option<String> = match &self.state {
+            WorkunitState::Completed { time_span } => Some(format!(
+                " ({})",
+                format_workunit_duration(Duration::from(time_span.duration))
+            )),
+            WorkunitState::Started { start_time, .. } if canceled => Some(format!(
+                " ({})",
+                format_workunit_duration(start_time.elapsed().unwrap_or_default())
+            )),
+            _ => None,
         };
 
         /* This length calculation doesn't treat multi-byte unicode charcters identically
@@ -360,7 +356,7 @@ pub enum ArtifactOutput {
     Snapshot(Arc<dyn DirectoryDigest>),
 }
 
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, Default)]
 pub struct WorkunitMetadata {
     pub desc: Option<String>,
     pub message: Option<String>,
@@ -372,25 +368,6 @@ pub struct WorkunitMetadata {
     pub remote_action: Option<hashing::Digest>,
     pub artifacts: Vec<(String, ArtifactOutput)>,
     pub user_metadata: Vec<(String, UserMetadataItem)>,
-    pub log_duration: bool,
-}
-
-impl Default for WorkunitMetadata {
-    fn default() -> Self {
-        Self {
-            desc: None,
-            message: None,
-            stdout: None,
-            stderr: None,
-            local_command: None,
-            local_action: None,
-            remote_command: None,
-            remote_action: None,
-            artifacts: Vec::new(),
-            user_metadata: Vec::new(),
-            log_duration: true,
-        }
-    }
 }
 
 /// Abstract id for passing user metadata items around

src/rust/workunit_store/src/tests.rs

@@ -283,7 +283,3 @@ fn format_duration_over_one_hour() {
     assert_eq!(format_workunit_duration(Duration::from_secs_f64(5445.5)), "90m 45.5s");
 }
 
-#[test]
-fn workunit_metadata_defaults_log_duration_to_true() {
-    assert!(WorkunitMetadata::default().log_duration);
-}