Release 4.8.0

[pascalwengerter]

Waiting for

• [full-ci] Apply sorting before pagination #6136
• improve people sharing sidebar #6176

Release checklist

• pin release issue @pascalwengerter
• prepare release rc: @pascalwengerter
  • create a branch release-4.8.0 @pascalwengerter
  • update the version in packages/web-integration-oc10/appinfo/info.xml @pascalwengerter
  • update the version in package.json @pascalwengerter
  • update the version in sonar-project.properties @pascalwengerter
  • move changelog/unreleased/* to changelog/VERSION_YYYY-MM-DD @pascalwengerter
  • update the ocis commit id in .drone.env to the most recent one from ocis master (let's see how it goes)
  • commit, push and create draft PR ([full-ci] Prepare v4.8.0 release #6180) for this branch @pascalwengerter
• create pre release tag v4.8.0-rc1 from the release branch @pascalwengerter
• smoke test
  • against oCIS @pascalwengerter
  • against oc10 standalone @pascalwengerter
  • against oc10 as app installation @kulmann
  • against oCIS wopi example / app provider @kulmann
• if needed, fix issues or write down known issues
• update YYYY-MM-DD to current date in changelog/VERSION_YYYY-MM-DD
• Make sure translations are up to date by updating them in Transifex and restarting translation sync job https://drone.owncloud.com/owncloud/translation-sync/ @pascalwengerter
• repeat above steps if a new rc is needed
• Run translations sync job once again
• go to the releases section and click Draft a new Release. Use v4.8.0 as a tag (the v prefix is important) and 4.8.0 as name and publish it
• ping in internal #btr channel to create a signed release and ask them to upload it to a) the github release page, b) marketplace.owncloud.com, c) portal.owncloud.com, d) customer.owncloud.com
• merge release branch [full-ci] Prepare v4.8.0 release #6180 back to master (CI must be green)

[kulmann]

Smoke test rc2 against oc10 app

• ✔️ as gunter - upload arch/mips folder from linux kernel (1945 files)

  • progress bar is not sticky
  • expanding the upload progress section slows down browser & upload time significantly

• ✔️ as gunter - share the folder to alice as viewer
  - sharing is not possible before the upload finished (user invite field doesn't stay focussed)
  - ❌ for reaching the invite form field one needs to tab through the whole file list until the sidebar is reached (focus should be set to sidebar or sidebar panel instead, depending on a11y needs)

• ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

• ✔️ as alice - try do delete file from shared folder
  - individual delete action not visible, good
  - batch delete action not visible, good
  - context menu action not visible, good

• ✔️ as alice - try to add file
  - not possible (which is expected) but drag & drop upload didn't handle it. opened file in new tab instead.

• ❌ as alice - copy 16 folders from share to home

  • no visible feedback that it's in progress
  • UI still weirdly usable, ended up in an active upload drop zone. Needed a page reload to be usable again.
  • folder listing after copy shows ? as folder size on some of the copied folders.

• ✔️ as gunter - add new file to share

• ✔️ as alice - receive new file in existing share

• ✔️ as gunter - unshare folder from shared with others

• ✔️ as alice - try to revisit old share

  • shows resource not found upon page reload, good
  • going back to All files or Shared with me doesn't list the share anymore, good

• ✔️ as gunter - share folder with alice again, but as editor
  - setting and removing an expiration date work as expected, good

• ✔️ as alice - rename file

  • via right sidebar, works, good
  • via context menu, works, good

• ✔️ as gunter - add file

• ✔️ as alice - delete file

  • via right sidebar, works, good
  • via context menu, works, good
  • via batch action, works, good

• ✔️ as alice - create public link on any folder

• ✔️ as alice delete file and recover it

• ✔️ as alice create version of textfile

• ✔️ as alice view version history of text file

• ✔️ as alice download newest version of text file

• ✔️ download older version of text file

• ✔️ restore older version of text file

  • no visible feedback about the success
  • preview is not updated

• ✔️ as alice - upload avatar in classic UI

  • see own avatar in top bar (far right)
  • login as gunter, having a share with alice
    • shared with others page loads and shows avatars

• ✔️ as alice, move a file into subfolder via drag and drop

• ✔️ as alice, move multiple files & folders into subfolder via drag and drop

• ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

Findings from new smoke testing:

• for reaching the invite form field one needs to tab through the whole file list until the sidebar is reached (focus should be set to sidebar or sidebar panel instead, depending on a11y needs)
• when a share fails, the submit button of the form stays in the disabled state with spinner. Needs to reset itself instead.

[pascalwengerter]

for reaching the invite form field one needs to tab through the whole file list until the sidebar is reached (focus should be set to sidebar or sidebar panel instead, depending on a11y needs => can't reproduce, upon opening the share panel (contextmenu or quickaction) the focus is at the top of the sidebar in Firefox)

[pascalwengerter]

Smoke test rc2 against oCIS from binary

• ✔️ as admin - upload apps folder from ownCloud core without files_external (~2.500 files)

  • progress bar is not sticky
  • expanding the upload progress section slows down browser & upload time significantly

• ✔️ as admin - share the folder to einstein as viewer
  - sharing is not possible before the upload finished (user invite field doesn't stay focussed)
  - ❌ for reaching the invite form field one needs to tab through the whole file list until the sidebar is reached (focus should be set to sidebar or sidebar panel instead, depending on a11y needs)

• ✔️ as einstein - accept share. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

• ✔️ as einstein - try do delete file from shared folder
  - individual delete action not visible, good
  - batch delete action not visible, good
  - context menu action not visible, good

• ✔️ as einstein - try to add file
  - not possible (which is expected) but drag & drop upload didn't handle it. opened file in new tab instead.

• ✔️ as einstein - copy 16 folders from share to home

  • no visible feedback that it's in progress

• ✔️ as admin - add new file to share

• ✔️ as einstein - receive new file in existing share

• ✔️ as admin - unshare folder from shared with others

  • ❌ resource stays in "Shared with others" resource table until page navigation/reload

• ✔️ as einstein - try to revisit old share

  • shows resource not found upon page reload, good
  • going back to All files or Shared with me doesn't list the share anymore, good

• ✔️ as admin - share folder with einstein again, but as editor

• ✔️ as einstein - rename file

  • via right sidebar, works, good
  • via context menu, works, good
  • ❌ renaming form input value includes file plus extension

• ✔️ as einstein - add file

• ✔️ as einstein - delete file

  • via right sidebar, works, good
  • via context menu, works, good
  • via batch action, works, good

• ✔️ as einstein - create public link on any folder

  • ❌ file size on folder seems broken

• ✔️ as einstein delete file and recover it

• ✔️ as einstein create version of textfile

• ✔️ as einstein view version history of text file

• ✔️ as einstein download newest version of text file

• ❌ download older version of text file

• ✔️ restore older version of text file

  • no visible feedback about the success

• ✔️ as einstein, move a file into subfolder via drag and drop

• ✔️ as einstein, move multiple files & folders into subfolder via drag and drop

• ✔️ as einstein, navigate into a folder, open right sidebar without selection, share current folder with admin

[kulmann]

Smoke test rc2 with ocis_wopi deployment example

• ❌ app provider apps don't have icons/images in the context menu anymore (collabora, onlyoffice, codimd) 😢
• ✔️ opening a lorem-ipsum.md file in codimd works as expected
• ❌ opening a lorem-ipsum.docx file in collabora gives error message "No disk space left on server, please contact the server administrator to continue.". Document doesn't load.
• ❌ directly opening the same docx file a second time in collabora gives error message "The document could not be locked, and is opened in read-only mode. Server returned this reason: The file was locked by another online editor". Shows the document in read only mode.
• ✔️ uploading a new file, it opens successfully in OnlyOffice, but only on first load. Second load is broken with same error messages as above.

Might be that files are not being unlocked. Needs further investigation. App provider is unusable for me.

[pascalwengerter]

Smoke test rc2 standalone against oc10 app

• ✔️ as admin - upload apps folder from ownCloud core without files_external (~2.500 files)

  • progress bar is not sticky
  • expanding the upload progress section slows down browser & upload time significantly

• ✔️ as admin - share the folder to alice as viewer
  - sharing is not possible before the upload finished (user invite field doesn't stay focussed)
  - ❌ for reaching the invite form field one needs to tab through the whole sidebar heading (focus should be set to sidebar or sidebar panel instead, depending on a11y needs)

• ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

• ✔️ as alice - try do delete file from shared folder
  - individual delete action not visible
  - batch delete action not visible
  - context menu action not visible

• ✔️ as alice - try to add file
  - not possible (which is expected) but drag & drop upload didn't handle it. opened file in new tab instead.

• ❌ as alice - copy 6 images from share to home

  • no visible feedback that it's in progress
  • folder listing after copy shows ? as folder size on some of the copied folders.

• ✔️ as admin - add new file to share

• ✔️ as alice - receive new file in existing share

• ✔️ as admin - unshare folder from shared with others

• ✔️ as alice - try to revisit old share

  • shows resource not found upon page reload
  • going back to All files or Shared with me doesn't list the share anymore

• ✔️ as admin - share folder with alice again, but as editor
  - setting and removing an expiration date work as expected

• ✔️ as alice - rename file

  • via right sidebar, works
  • via context menu, works

• ✔️ as alice - add file

• ✔️ as alice - delete file

  • via right sidebar, works
  • via context menu, works
  • via batch action, works

• ✔️ as alice - create public link on any folder

  • ❌ folder size is not displayed

• ✔️ as alice delete file and recover it

• ✔️ as alice create version of textfile

• ✔️ as alice view version history of text file

• ✔️ as alice download newest version of text file

• ✔️ download older version of text file

• ✔️ restore older version of text file

  • no visible feedback about the success
  • preview is not updated

• ✔️ as alice - upload avatar in classic UI

  • see own avatar in top bar (far right)
  • login as admin, having a share with alice
    • shared with others page loads and shows avatars

• ✔️ as alice, move a file into subfolder via drag and drop

• ✔️ as alice, move multiple files & folders into subfolder via drag and drop

• ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with admin

[pascalwengerter]

Smoke test rc2 with ocis_wopi deployment example

* x app provider apps don't have icons/images in the context menu anymore (collabora, onlyoffice, codimd) cry

app provider apps/images don't need a fix in web, rather in oCIS/Reva from what I see since we merged #5985. There's .ico "icons" referenced in the deployment example as, e.g., APP_PROVIDER_WOPI_DRIVER_APP_ICON_URI but those arrive as URLs which the OcIcon component can't handle (while they should be referenced as img for the OcImg to be rendered next to the external app actions)

EDIT: Already broken in web v4.7.0 and a backend announcement problem, so no release blocker from my POV

* x opening a lorem-ipsum.docx file in collabora gives error message "No disk space left on server, please contact the server administrator to continue.". Document doesn't load.

* x directly opening the same docx file a second time in collabora gives error message "The document could not be locked, and is opened in read-only mode. Server returned this reason: The file was locked by another online editor". Shows the document in read only mode.

Worked for me, maybe a docker problem on your side?

[kulmann]

Smoke test rc2 with ocis_wopi deployment example

• ❌ app provider apps don't have icons/images in the context menu anymore (collabora, onlyoffice, codimd) 😢
• ✔️ opening a lorem-ipsum.md file in codimd works as expected
• ❌ opening a lorem-ipsum.docx file in collabora gives error message "No disk space left on server, please contact the server administrator to continue.". Document doesn't load.
• ❌ directly opening the same docx file a second time in collabora gives error message "The document could not be locked, and is opened in read-only mode. Server returned this reason: The file was locked by another online editor". Shows the document in read only mode.
• ✔️ uploading a new file, it opens successfully in OnlyOffice, but only on first load. Second load is broken with same error messages as above.

Might be that files are not being unlocked. Needs further investigation. App provider is unusable for me.

Nice, pruned my containers/images and fired the wopi example up again. Works now. Weird... the only remaining issue is the broken icon support.