Purge remaining port-batch markers missed by the phase cleanup #30885
Claude / Claude Code Review
completed
May 18, 2026 in 23m 57s
Code review found 4 potential issues
Found 5 candidates, confirmed 4. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/host_fn.rs:516-517 |
R-2 markers survive in .ts codegen files (file-type gap, paired with host_fn.rs rewrite) |
| 🟡 Nit | src/runtime/api/filesystem_router.rs:610 |
Mechanical R-2→'noalias re-entry' rewrite produced self-contradicting SAFETY labels |
Annotations
Check warning on line 517 in src/jsc/host_fn.rs
claude / Claude Code Review
R-2 markers survive in .ts codegen files (file-type gap, paired with host_fn.rs rewrite)
The e97f7784 R-2 sweep ran with `--type rust`, missing TypeScript: `src/codegen/class-definitions.ts:121` still reads '(R-2 noalias re-entrancy)' and `src/codegen/generate-classes.ts:2866` still reads '// R-2 Phase 3: default flipped to `sharedThis: true`' — and :2870-2871 explicitly cross-references 'src/jsc/host_fn.rs alongside the legacy `&mut` originals', whose paired comment this PR just rewrote at :510/:516-517 to drop both '(R-2 noalias re-entrancy)' and 'Phase 3 of `R-2-design.md`'. Same
Check warning on line 610 in src/runtime/api/filesystem_router.rs
claude / Claude Code Review
Mechanical R-2→'noalias re-entry' rewrite produced self-contradicting SAFETY labels
nit: The e97f7784 sweep mechanically replaced `SAFETY (R-2):` → `SAFETY (noalias re-entry):` here and at `node_fs.rs:778/958`, but at all three sites the body explicitly says there IS no re-entry ('is pure (no JS re-entry)' / 'never across a JS re-entry point' / 'held only across the libuv enqueue'). The original `(R-2)` was a bare workstream tag — per this PR's own pattern at non-re-entrant R-2 sites (e.g. `filesystem_router.rs:473` `// R-2: snapshot` → `// Snapshot`), it should have been dropp
Loading