Commit 9044d39
committed
http: emit ServerResponse 'close' on client disconnect
When the canUseInternalAssignSocket fast path is taken,
assignSocketInternal stores onServerResponseClose on the socket via
setCloseCallback (self[kCloseCallback] = ...) instead of registering a
real EventEmitter listener. The 'close' event the Duplex fires when the
underlying handle goes away never triggered that stored callback, so
ServerResponse.on('close', ...) never fired on client abort.
Hook NodeHTTPServerSocket.emit so the stored callback runs when the
socket emits 'close', mirroring what ServerResponse.prototype.emit
already does for the response side.
Fixes #292191 parent 7c75a87 commit 9044d39
File tree
2 files changed
+63
-0
lines changed- src/js/node
- test/regression/issue
2 files changed
+63
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1106 | 1106 | | |
1107 | 1107 | | |
1108 | 1108 | | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
1109 | 1121 | | |
1110 | 1122 | | |
1111 | 1123 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
0 commit comments