Check more command line options for "compatibility"

Adds some additional checks of the command line options. Adds warnings
for
* options ignored when using "flex" output
* options ignored when using "null" output
* incompatible options setting the output projection

The function `opt->get_name(false, true)` used here returns a string
with all the (short and long) names of a command line option.

Author: joto

src/command-line-parser.cpp

@@ -128,24 +128,46 @@ void print_version()
 #endif
 }
 
-static void check_options(options_t *options)
+static void check_options_output_flex(CLI::App const &app)
 {
-    if (options->append && options->create) {
-        throw std::runtime_error{"--append and --create options can not be "
-                                 "used at the same time!"};
-    }
-
-    if (options->append && !options->slim) {
-        throw std::runtime_error{"--append can only be used with slim mode!"};
+    auto const ignored_options = app.get_options([](CLI::Option const *option) {
+        return option->get_group() == "Pgsql output options" ||
+               option->get_name() == "--tablespace-main-data" ||
+               option->get_name() == "--tablespace-main-index";
+    });
+
+    for (auto const *opt : ignored_options) {
+        if (opt->count()) {
+            log_warn("Ignoring option {} for 'flex' output",
+                     opt->get_name(false, true));
+        }
     }
+}
 
-    if (options->droptemp && !options->slim) {
-        throw std::runtime_error{"--drop only makes sense with --slim."};
+static void check_options_output_null(CLI::App const &app)
+{
+    auto const ignored_options = app.get_options([](CLI::Option const *option) {
+        return option->get_group() == "Pgsql output options" ||
+               option->get_group() == "Expire options" ||
+               option->get_name() == "--style" ||
+               option->get_name() == "--disable-parallel-indexing" ||
+               option->get_name() == "--number-processes";
+    });
+
+    for (auto const *opt : ignored_options) {
+        if (opt->count()) {
+            log_warn("Ignoring option {} for 'null' output",
+                     opt->get_name(false, true));
+        }
     }
+}
 
-    if (options->append && options->middle_database_format != 1) {
-        throw std::runtime_error{
-            "Do not use --middle-database-format with --append."};
+static void check_options_output_pgsql(CLI::App const &app, options_t *options)
+{
+    if (app.count("--latlong") + app.count("--merc") + app.count("--proj") >
+        1) {
+        throw std::runtime_error{"You can only use one of --latlong, -l, "
+                                 "--merc, -m, --proj, and -E"};
     }
 
     if (options->hstore_mode == hstore_column::none &&
@@ -162,6 +184,27 @@ static void check_options(options_t *options)
                  "ignored.");
         options->enable_hstore_index = false;
     }
+}
+
+static void check_options(options_t *options)
+{
+    if (options->append && options->create) {
+        throw std::runtime_error{"--append and --create options can not be "
+                                 "used at the same time!"};
+    }
+
+    if (options->append && !options->slim) {
+        throw std::runtime_error{"--append can only be used with slim mode!"};
+    }
+
+    if (options->droptemp && !options->slim) {
+        throw std::runtime_error{"--drop only makes sense with --slim."};
+    }
+
+    if (options->append && options->middle_database_format != 1) {
+        throw std::runtime_error{
+            "Do not use --middle-database-format with --append."};
+    }
 
     if (options->cache < 0) {
         options->cache = 0;
@@ -202,11 +245,6 @@ static void check_options(options_t *options)
                  "target SRS is not Mercator (EPSG:3857). Expire disabled!");
         options->expire_tiles_zoom = 0;
     }
-
-    if (options->output_backend == "gazetteer") {
-        log_warn(
-            "The 'gazetteer' output is deprecated and will soon be removed.");
-    }
 }
 
 // NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,hicpp-avoid-c-arrays,modernize-avoid-c-arrays)
@@ -646,6 +684,18 @@ options_t parse_command_line(int argc, char *argv[])
         return options;
     }
 
+    if (options.output_backend == "flex") {
+        check_options_output_flex(app);
+    } else if (options.output_backend == "gazetteer") {
+        log_warn(
+            "The 'gazetteer' output is deprecated and will soon be removed.");
+    } else if (options.output_backend == "null") {
+        check_options_output_null(app);
+    } else if (options.output_backend == "pgsql" ||
+               options.output_backend.empty()) {
+        check_options_output_pgsql(app, &options);
+    }
+
     if (options.input_format == "auto") {
         options.input_format.clear();
     }