From 319ef841345b7f7cb30b533b1e1a680ea1b8cc35 Mon Sep 17 00:00:00 2001 From: ThomasBreuer Date: Wed, 26 Nov 2025 10:16:35 +0100 Subject: [PATCH] remove a GAP function that is now provided by GAP In Oscar.jl v1.6, we have at least GAP.jl v0.16.1. This version provides at least v1.3.10 of the GAP package CTblLib, and this contains the function `IsAtlasCharacterTable`. Before this became available, it had been provided inside Oscar, via the GAP package `OscarInterface`. --- gap/pkg/OscarInterface/gap/OscarInterface.gi | 35 -------------------- 1 file changed, 35 deletions(-) diff --git a/gap/pkg/OscarInterface/gap/OscarInterface.gi b/gap/pkg/OscarInterface/gap/OscarInterface.gi index ae064a514cf4..cdea09e744b6 100644 --- a/gap/pkg/OscarInterface/gap/OscarInterface.gi +++ b/gap/pkg/OscarInterface/gap/OscarInterface.gi @@ -184,38 +184,3 @@ InstallMethod( IsHandledByNiceMonomorphism, fi; return false; end ); - -############################################################################ - -# The following can be removed as soon as the CTblLib package provides it -# (not yet in CTblLib v1.3.9). -if not IsBound( IsAtlasCharacterTable ) then - DeclareProperty( "IsAtlasCharacterTable", IsNearlyCharacterTable ); - - InstallMethod( IsAtlasCharacterTable, - [ "IsOrdinaryTable" ], - tbl -> PositionSublist( InfoText( tbl ), - "origin: ATLAS of finite groups" ) <> fail ); - - InstallMethod( IsAtlasCharacterTable, - [ "IsBrauerTable" ], - tbl -> IsAtlasCharacterTable( OrdinaryCharacterTable( tbl ) ) ); - - AddSet( CTblLib.SupportedAttributes, "IsAtlasCharacterTable" ); - - DatabaseAttributeAddX( CTblLib.Data.IdEnumerator, rec( - identifier:= "IsAtlasCharacterTable", - type:= "values", - name:= "IsAtlasCharacterTable", - neededAttributes:= [ "InfoText" ], - create:= function( attr, id ) - local infotext; - - infotext:= attr.idenumerator.attributes.InfoText; - return PositionSublist( infotext.attributeValue( infotext, id ), - "origin: ATLAS of finite groups" ) <> fail; - end, - ) ); - - CTblLib.ExtendAttributeOfIdEnumeratorExt( "IsAtlasCharacterTable", true ); -fi;