eln: disk images are LVM by default (HMS-11050, HMS-10803) - #2538
Draft
supakeen wants to merge 8 commits into
Draft
eln: disk images are LVM by default (HMS-11050, HMS-10803)#2538supakeen wants to merge 8 commits into
supakeen wants to merge 8 commits into
Conversation
Clean up the ELN disk definitions by splitting out the partitions and defining both types of partition tables in use (root is plain XFS without XBOOTLDR, root is LVM with XBOOTLDR). This keeps all the hysterical raisins that are present and thus no checksums change. It might be slightly suboptimal but this reorganization will make the following commits much easier to digest. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
The LVM partition table used on Azure used different partition size for the BIOS boot, ESP, and XBOOTLDR partition from the defaults. Let's share the sizes between both. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
The LVM partition tables had no labels on the filesystems for XBOOTLDR and the ESP. Let's share them with the non-LVM partition table instead. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
The LVM partition tables erroneously set the GUID for the XBOOTLDR partition to filesystem data. Instead use the DPS [1] UUID for XBOOTLDR, the same as the non-LVM partition table. [1]: https://uapi-group.org/specifications/specs/discoverable_partitions_specification/ Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
The BIOS partition for the LVM partition table layout was in the middle of other partitions. In the non-LVM table it's at the front. Let's move it for LVM. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
The s390x and ppc64le partition tables set empty labels for their filesystems. Let's share the labels with the rest of the partitions instead. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
For the non-LVM partition table use DPS [1] UUIDs for the GPT partition tables for the root partition. This only affects x86_64 and aarch64 as we use DOS partition tables for s390x and ppc64le. Note that for the LVM partition table we use the LVM type UUID for the partition that contains the LVM layout thus nothing changes there. [1]: https://uapi-group.org/specifications/specs/discoverable_partitions_specification/ Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
Move all disk images to use the LVM layout by default, dropping the non-LVM layout definition in the process. This unifies the disk layout that ELN uses across all disk artifacts and aligns it with the wants of the RHEL virt group. Users are able to define other layouts as they desire, RHEL also publishes non-LVM images to various clouds. These are configured in Pungi at the moment but we *might* want to introduce separate image types for LVM vs no-LVM or provide a different selection mechanism to make it easier to have two standard layouts. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
supakeen
changed the title
supakeen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a bunch of clean-up in the beginning, aligning the two partition tables that were in effect closer and closer; it then gets rid of the non-LVM version and switches all disk images over to use an LVM-based layout.
For passers-by. This isn't a final thing. Discussions are still ongoing surrounding:
ec2,ec2-lvm,azure,azure-lvm, for example).