From e6ab4201b14e4e2c86d5905e25c425ee52529c23 Mon Sep 17 00:00:00 2001 From: Daniel Erez Date: Tue, 18 Aug 2026 18:18:21 +0300 Subject: [PATCH] Fix volume reconciler test: drop obsolete PVCRef assertion The volume reconciler unit test asserted `spec.PVCRef` on the CRD VolumeSpec, but that field no longer exists, so the `volume` package fails to compile and both "Run unit tests" and "Check Go and proto code" are red on main: internal/controllers/volume/volume_reconciler_function_test.go:103:15: spec.PVCRef undefined (type v1alpha1.VolumeSpec has no field or method PVCRef) Root cause is a semantic merge conflict between two PRs, both authored by @akshaynadkarni: - #341 (OSAC-3274) removed pvcRef/pvRef from VolumeSpec, merged first (2026-08-17). - #339 (OSAC-3276) added the reconciler test referencing spec.PVCRef, merged second (2026-08-18) off a branch that predated #341 and was not re-validated against the updated main. Each PR was green in isolation; combined on main they do not compile. Remove the stale assertion to restore the build. PVC/PV tracking is planned for a future VolumeAttachment resource (OSAC-3278), not the Volume itself, so there is nothing to re-point the assertion at. Co-Authored-By: Claude Opus 4.8 --- .../controllers/volume/volume_reconciler_function_test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/fulfillment-service/internal/controllers/volume/volume_reconciler_function_test.go b/fulfillment-service/internal/controllers/volume/volume_reconciler_function_test.go index 4942789b06..05db0a3e96 100644 --- a/fulfillment-service/internal/controllers/volume/volume_reconciler_function_test.go +++ b/fulfillment-service/internal/controllers/volume/volume_reconciler_function_test.go @@ -100,7 +100,6 @@ var _ = Describe("buildSpec", func() { Expect(spec.StorageTier).To(Equal("gold")) Expect(spec.SizeGiB).To(Equal(int64(100))) Expect(spec.AccessMode).To(Equal(osacv1alpha1.VolumeAccessModeReadWriteOnce)) - Expect(spec.PVCRef).To(BeNil()) }) It("maps ReadWriteMany access mode", func() {