[e2e] Drop Windows Server 2019 support

This commit removes Server2019 from supported versions, provider image
selectors,container image selection, and PowerShell compatibility workarounds.

All available Azure Marketplace images for the 2019-datacenter-smalldisk
SKU have the OpenSSH regression introduced in KB5044277 (Oct 2024, OS
Build 17763.6414). The previously pinned version 17763.6293.240905 has
been deprecated and removed. Windows Server 2019 mainstream support
ended January 2024.

Author: jrvaldes

test/e2e/network_test.go

@@ -864,8 +864,6 @@ func (tc *testContext) getPodIP(selector metav1.LabelSelector) (string, error) {
 // getWindowsServerContainerImage gets the appropriate WindowsServer image based on the OS version
 func (tc *testContext) getWindowsServerContainerImage() string {
 	switch tc.windowsServerVersion {
-	case windows.Server2019:
-		return "mcr.microsoft.com/powershell:lts-nanoserver-1809"
 	case windows.Server2022:
 	case windows.Server2025:
 		// 2022-based container images are compatible with Windows Server 2025

test/e2e/providers/aws/aws.go

@@ -59,8 +59,6 @@ func newEC2Client(region string) (*ec2.EC2, error) {
 // pattern Windows_Server-$version-variant-YYYY.MM.DD and the filter will grab all AMIs that match the filter.
 func getWindowsAMIFilter(windowsServerVersion windows.ServerVersion) string {
 	switch windowsServerVersion {
-	case windows.Server2019:
-		return "Windows_Server-2019-English-Core-Base-????.??.??"
 	case windows.Server2025:
 		return "Windows_Server-2025-English-Core-Base-????.??.??"
 	case windows.Server2022:

test/e2e/providers/azure/azure.go

@@ -47,10 +47,6 @@ func New(clientset *clusterinfo.OpenShift, infraStatus *config.InfrastructureSta
 // newAzureMachineProviderSpec returns an AzureMachineProviderSpec generated from the inputs, or an error
 func (p *Provider) newAzureMachineProviderSpec(location, zone, vmSize, publicLoadBalancer string, windowsServerVersion windows.ServerVersion) (*mapi.AzureMachineProviderSpec, error) {
 	imageVersion := defaultImageVersion
-	if windowsServerVersion == windows.Server2019 {
-		// TODO: remove when VM SSH issue is patched in Azure cloud
-		imageVersion = "17763.6293.240905"
-	}
 	return &mapi.AzureMachineProviderSpec{
 		TypeMeta: meta.TypeMeta{
 			APIVersion: "azureproviderconfig.openshift.io/v1beta1",
@@ -345,8 +341,6 @@ func (p *Provider) ensureWindowsCSIDaemonSet(client client.Interface) error {
 // getImageSKU returns the SKU based on the Windows Server version
 func getImageSKU(windowsServerVersion windows.ServerVersion) string {
 	switch windowsServerVersion {
-	case windows.Server2019:
-		return "2019-datacenter-smalldisk"
 	case windows.Server2025:
 		return "2025-datacenter-smalldisk"
 	case windows.Server2022:

test/e2e/providers/gcp/gcp.go

@@ -106,8 +106,6 @@ func (p *Provider) CreatePVC(_ client.Interface, _ string, _ *core.PersistentVol
 // getImage returns the image based on the Windows Server version
 func getImage(windowsServerVersion windows.ServerVersion) string {
 	switch windowsServerVersion {
-	case windows.Server2019:
-		return "projects/windows-cloud/global/images/family/windows-2019-core"
 	case windows.Server2025:
 		return "projects/windows-cloud/global/images/family/windows-2025-core"
 	case windows.Server2022:

test/e2e/validation_test.go

@@ -35,7 +35,6 @@ import (
 	"github.com/openshift/windows-machine-config-operator/pkg/secrets"
 	"github.com/openshift/windows-machine-config-operator/pkg/servicescm"
 	"github.com/openshift/windows-machine-config-operator/pkg/windows"
-	e2e_windows "github.com/openshift/windows-machine-config-operator/test/e2e/windows"
 )
 
 const (
@@ -354,10 +353,7 @@ func (tc *testContext) ensureTestRunnerRBAC() error {
 func (tc *testContext) runPowerShellSSHJob(name, command, ip string) (string, error) {
 	// Modify command to work when default shell is the newer Powershell version present on Windows Server 2022 and
 	// later
-	powershellDefaultCommand := command
-	if tc.windowsServerVersion != e2e_windows.Server2019 {
-		powershellDefaultCommand = strings.ReplaceAll(command, "\\\"", "\"")
-	}
+	powershellDefaultCommand := strings.ReplaceAll(command, "\\\"", "\"")
 
 	keyMountDir := "/private-key"
 	sshOptions := "-o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null"

test/e2e/windows/version.go

@@ -3,8 +3,6 @@ package windows
 type ServerVersion string
 
 const (
-	// Server2019 represent Windows Server 2019
-	Server2019 ServerVersion = "2019"
 	// Server2022 represent Windows Server 2022
 	Server2022 ServerVersion = "2022"
 	// Server2025 represent Windows Server 2025
@@ -13,11 +11,10 @@ const (
 
 // SupportedVersions are the Windows Server versions supported by the e2e test.
 // "" implies the default which is Server2022
-var SupportedVersions = []ServerVersion{Server2019, Server2022, Server2025, ""}
+var SupportedVersions = []ServerVersion{Server2022, Server2025, ""}
 
 // BuildNumber returns the build for a given server version as defined by Microsoft
 var BuildNumber = map[ServerVersion]string{
-	Server2019: "10.0.17763",
 	Server2022: "10.0.20348",
 	Server2025: "10.0.26100",
 }